Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase max size for passwords - Solving the "E-Mail address already in use" Error #129

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Increase max size for passwords - Solving the "E-Mail address already in use" Error #129

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e26d48
Increased the max size for passwords from 60 to 254 - see #88.
bioluks Mar 26, 2024
5e8a762
Revert "Increased the max size for passwords from 60 to 254 - see #88."
KiARC Oct 1, 2024
4ba60a9
Create migration to extend maxlen of 'password' column to 254
KiARC Oct 1, 2024
6a9a84d
Merge pull request #1 from KiARC/registration-database-fix
bioluks Nov 5, 2024
b712712
Merge branch 'ferdium:main' into registration-database-fix
bioluks Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion database/migrations/1503250034279_user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default class extends BaseSchema {
table.increments();
table.string('username', 80).notNullable();
table.string('email', 254).notNullable().unique();
table.string('password', 60).notNullable();
table.string('password', 254).notNullable();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thank you for raising this PR. I haven't tested this yet (been having some personal issues that prevent me from reviewing and testing stuff)....

Nevertheless, we shouldn't modify migrations file, we should rather create a new one and modify that field to allow up to 254. Would you be able to create a new migration following adonisjs guides and change this PR accordingly?

Thank you so much in advance!

table.json('settings');
table.timestamps();
});
Expand Down