feat(rc): Add custom signals support #8602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also takes care of setting the signals in the fetch request
🦋 Changeset detectedLatest commit: 9e1b157 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ashish-kothari
changed the title
ashish-kothari
requested review from
9kubczas4
and removed request for
9kubczas4
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
- Add new `getWithTransaction` and `setWithTransaction` APIs - Refactor generic `get` and `set` APIs for code reuse - Update `setCustomSignals` to perform upsert operation in a single transaction.
erikeldridge
approved these changes
Oct 28, 2024
| @@ -9,6 +9,12 @@ import { FirebaseApp } from '@firebase/app'; | |||
| // @public | |||
| export function activate(remoteConfig: RemoteConfig): Promise<boolean>; | |||
|
|
|||
| // @public | |||
| export interface CustomSignals { | |||
| // (undocumented) | |||
There was a problem hiding this comment.
Hmm. This would appear to indicate we've missed documentation on a public API, but I see a comment on CustomSignals in public_types.ts, so it's unclear what more we should be doing. This would be a question for the core JS team. I see getRemoteConfig is also flagged as undocumented, so this may be a non-issue.
There was a problem hiding this comment.
This indicates there's no documentation comment for the key/value pair here which it looks like probably isn't needed here given the thorough documentation on the parent interface.
hsubox76
reviewed
Oct 28, 2024
- Removed changes to firebase/compat and remote-config-compat packages.
Changeset File Check ✅
|
ashish-kothari
force-pushed
the
ashish-kothari/rc-custom-targeting
branch
from
f0a9278
to
4dd52d3
Compare
ashish-kothari
force-pushed
the
ashish-kothari/rc-custom-targeting
branch
from
4dd52d3
to
805db83
Compare
|
I heard my approval motivated some discussion, so I'll add additional context:
|
- Handle numeric custom signal values - Handle empty custom signal map - Log error instead of throwing when exceeding limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.