Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rc): Add custom signals support #8602

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(rc): Add custom signals support #8602

wants to merge 18 commits into from

Commits on Oct 25, 2024

  1. Add support to set/update custom signals 

    - Also takes care of setting the signals in the fetch request
    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4cfd43b View commit details
    Browse the repository at this point in the history

  2. Add explanatory comments

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2bd7dc0 View commit details
    Browse the repository at this point in the history

  3. Minor fixes in the custom signals storage API

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    33444c5 View commit details
    Browse the repository at this point in the history

  4. Add setCustomSignals() to RemoteConfigCompat

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ea317aa View commit details
    Browse the repository at this point in the history

  5. Add setCustomSignals() under firebase/compat

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ad74ca5 View commit details
    Browse the repository at this point in the history

  6. Address lint errors + add/fix few tests

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    77f1cb6 View commit details
    Browse the repository at this point in the history

  7. Add changeset

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ed9a8b1 View commit details
    Browse the repository at this point in the history

  8. Run yarn format

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    26ce7e1 View commit details
    Browse the repository at this point in the history

  9. Run yarn docgen:all

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f3a0f16 View commit details
    Browse the repository at this point in the history

  10. Add & update unit tests

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    44015b1 View commit details
    Browse the repository at this point in the history

  11. Run yarn format

    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3f7a55c View commit details
    Browse the repository at this point in the history

  12. Refactor setCustomSignals storage API 

    - Add new `getWithTransaction` and
`setWithTransaction` APIs
- Refactor generic `get` and `set` APIs for code
reuse
- Update `setCustomSignals` to perform upsert
operation in a single transaction.
    @ashish-kothari
    ashish-kothari committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    95df4e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Add unit test + improve public API documentation 

    - Removed changes to firebase/compat and
remote-config-compat packages.
    @ashish-kothari
    ashish-kothari committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ff99a7c View commit details
    Browse the repository at this point in the history

  2. Update changeset

    @ashish-kothari
    ashish-kothari committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    805db83 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Add limit checks on custom signals keys and values

    @ashish-kothari
    ashish-kothari committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fd7c6c2 View commit details
    Browse the repository at this point in the history

  2. Run yarn format

    @ashish-kothari
    ashish-kothari committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    832258b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Multiple bug fixes 

    - Handle numeric custom signal values
- Handle empty custom signal map
- Log error instead of throwing when exceeding limits
    @ashish-kothari
    ashish-kothari committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    07075dd View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Run yarn docgen:all

    @ashish-kothari
    ashish-kothari committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9e1b157 View commit details
    Browse the repository at this point in the history