1174 set log level to debug in golang #1236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We want to go through all of the log statements we have today and change non-essential stuff to DEBUG instead of INFO like it is today. We still want to log all of the levels if the right argument is passed. |
apascal07
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Do we need the changes in this file?
There was a problem hiding this comment.
I just moved it to a new file
apascal07
reviewed
Nov 13, 2024
go/core/logger/logger.go
Outdated
| @@ -26,10 +26,12 @@ import ( | |||
| func init() { | |||
| // TODO: Remove this. The main program should be responsible for configuring logging. | |||
There was a problem hiding this comment.
Has this TODO been resolved? How does the log level get configured by the user?
There was a problem hiding this comment.
yes, It is resolved, the user can set the log level like:
if err := genkit.Init(ctx, &genkit.Options{LogLevel: slog.LevelWarn}); err != nil {
log.Fatal(err)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually and seems like works
Checklist (if applicable):