-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1174 set log level to debug in golang #1236
Open
alonsopec89
wants to merge
6
commits into
next
Choose a base branch
from
1174-set-log-level-to-debug-in-golang
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9dd8189
put the level to debug
alonsopec89 2bda892
allow multiple levels of logs
alonsopec89 aee20f7
change no essentials to debug
alonsopec89 12c99ac
add level filter logger to another file
alonsopec89 1857ae8
resolve TODO: the main program should be responsable of the level log
alonsopec89 eb8d51b
Merge branch 'next' into 1174-set-log-level-to-debug-in-golang
alonsopec89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright 2024 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
// Package logger provides a context-scoped slog.Logger. | ||
package logger | ||
|
||
import ( | ||
"context" | ||
"log/slog" | ||
) | ||
|
||
// LevelFilterHandler is a custom handler that only logs DEBUG messages. | ||
type LevelFilterHandler struct { | ||
level slog.Level | ||
h slog.Handler | ||
} | ||
|
||
func (h *LevelFilterHandler) Enabled(ctx context.Context, level slog.Level) bool { | ||
// Display the message if its level is greater than or equal to the configured level | ||
return level >= h.level | ||
} | ||
|
||
func (h *LevelFilterHandler) Handle(ctx context.Context, r slog.Record) error { | ||
return h.h.Handle(ctx, r) | ||
} | ||
|
||
func (h *LevelFilterHandler) WithAttrs(attrs []slog.Attr) slog.Handler { | ||
return &LevelFilterHandler{ | ||
level: h.level, | ||
h: h.h.WithAttrs(attrs), | ||
} | ||
} | ||
|
||
func (h *LevelFilterHandler) WithGroup(name string) slog.Handler { | ||
return &LevelFilterHandler{ | ||
level: h.level, | ||
h: h.h.WithGroup(name), | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,10 +26,12 @@ import ( | |
func init() { | ||
// TODO: Remove this. The main program should be responsible for configuring logging. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Has this TODO been resolved? How does the log level get configured by the user? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, It is resolved, the user can set the log level like: if err := genkit.Init(ctx, &genkit.Options{LogLevel: slog.LevelWarn}); err != nil {
log.Fatal(err)
} |
||
// This is just a convenience during development. | ||
h := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{ | ||
Level: slog.LevelDebug, | ||
})) | ||
slog.SetDefault(h) | ||
baseHandler := slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{}) | ||
debugHandler := &LevelFilterHandler{ | ||
h: baseHandler, | ||
level: slog.LevelDebug, | ||
} | ||
slog.SetDefault(slog.New(debugHandler)) | ||
} | ||
|
||
var loggerKey = base.NewContextKey[*slog.Logger]() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the changes in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just moved it to a new file