fix: @invertase update Vertex AI reranker app with proper model and setup and docs #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustolandia
added
bug
Gustolandia
force-pushed
the
@invertase/genkit/js/testapps/vertexai-reranker
branch
from
729f749
to
79e202a
Compare
pavelgj
reviewed
Nov 15, 2024
| @@ -8,7 +8,9 @@ | |||
| "compile": "tsc", | |||
| "build": "pnpm build:clean && pnpm compile", | |||
| "build:clean": "rimraf ./lib", | |||
| "build:watch": "tsc --watch" | |||
| "build:watch": "tsc --watch", | |||
| "genkit:dev": "cross-env GENKIT_ENV=dev pnpm dev", | |||
There was a problem hiding this comment.
This probably needs to be applied globally in all testapps -- we no longer need to set GENKIT_ENV and rely on cross-env
Suggested change
| "genkit:dev": "cross-env GENKIT_ENV=dev pnpm dev", | |
| "genkit:dev": "genkit start -- pnpm dev", |
pavelgj
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Vertex AI Reranker sample app to use the correct model (semantic-ranker-512@latest) and includes improvements to documentation and configurations. It ensures compatibility with the latest Vertex AI API and provides a comprehensive README for setup and usage.
Checklist (if applicable):