Fix optional PR tests #4705
Merged
Fix optional PR tests #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4705 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 254 254
Lines 30792 30792
=======================================
Hits 25508 25508
Misses 5284 5284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bchalios
force-pushed
the
fix_ab
branch
4 times, most recently
from
0159b8f
to
7ab1ae3
Compare
bchalios
added
the
Status: Awaiting review
roypat
reviewed
Jul 25, 2024
Optional pipeline started failing during a build failure in the rust benchmarks tests. During the build step, we build REVISION_A (main) and REVISION_B (tip of the PR commit) and pass it over to the subsequent pipeline steps that run the test. However, 'test_benchmarks.py' needs to build the benchmarks, running `cargo bench`. That step started failing when building 'aws-lc-rs-sys' because CMake is complaining that its CMakeCache.txt file is not in the same path as the one initially created. Since we anyway run `cargo bench` in the test there's not really need to pre-build firecracker. So, modify the buildkite pipeline logic to allow defining pipelines without the build step, and change the pipeline_pr_no_block.py to not use it. Signed-off-by: Babis Chalios <bchalios@amazon.es>
roypat
approved these changes
Jul 26, 2024
zulinx86
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change no block pipelines to not use the build step
Reason
No block pipeline runs rust benchmarks (among other things) which need to run
cargo benchto build those benchmarks. Problem is that when we use pre-build artifacts some build paths don't match leading to errors like this: https://buildkite.com/firecracker/firecracker-pr-optional/builds/8136#0190dfc2-bdd9-42fc-9471-91b816f43d3fSince we anyway rebuild these artifacts just do it in the test step and drop the build step.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.