Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional PR tests #4705

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix optional PR tests #4705

merged 1 commit into from
Jul 26, 2024

Commits on Jul 26, 2024

  1. fix(test): do not use build step for optional pipeline

    Optional pipeline started failing during a build failure in the rust
    benchmarks tests.
    
    During the build step, we build REVISION_A (main) and REVISION_B (tip of
    the PR commit) and pass it over to the subsequent pipeline steps that
    run the test.
    
    However, 'test_benchmarks.py' needs to build the benchmarks, running
    `cargo bench`. That step started failing when building 'aws-lc-rs-sys'
    because CMake is complaining that its CMakeCache.txt file is not in the
    same path as the one initially created.
    
    Since we anyway run `cargo bench` in the test there's not really need to
    pre-build firecracker. So, modify the buildkite pipeline logic to allow
    defining pipelines without the build step, and change the
    pipeline_pr_no_block.py to not use it.
    
    Signed-off-by: Babis Chalios <bchalios@amazon.es>
    bchalios committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b294af9 View commit details
    Browse the repository at this point in the history