Update runtime to 46 #104

A6GibKm · 2023-10-03T15:21:27Z

Closes #103

See https://gitlab.gnome.org/GNOME/totem/-/commit/b9f3ef5823d067d552444055a0e7ae3939dc5784

See https://gitlab.gnome.org/GNOME/totem/-/commit/72b21bdd269c33c4aaa93ebc48d88de0cfd1be10.

See https://gitlab.gnome.org/GNOME/totem/-/commit/f6e3571adc090c018e68d9c1e55688f9b16f8176

flathubbot · 2023-10-03T15:21:42Z

Started test build 70780

flathubbot · 2023-10-03T15:22:07Z

Build 70780 failed

A6GibKm · 2023-10-03T15:22:10Z

I was not able to get ffmpeg to build, no idea if going back to the extension is a bad idea.

org.gnome.Totem.json

flathubbot · 2023-10-03T19:38:15Z

Started test build 70834

flathubbot · 2023-10-03T19:42:27Z

Build 70834 failed

flathubbot · 2023-10-03T19:48:16Z

Started test build 70837

flathubbot · 2023-10-03T20:13:11Z

Build 70837 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/53491/org.gnome.Totem.flatpakref

See https://gitlab.gnome.org/GNOME/totem/-/commit/2c0feda81c492d85d058bff1e45d0bcd4ff8104b.

with-docs was removed.

We need https://gitlab.gnome.org/GNOME/gupnp-av/-/commit/9557768121d54fdcedabe7544863515d6a813354 to build the library and it is not yet in any release.

See flathub/io.github.celluloid_player.Celluloid@6d6d341

flathubbot · 2023-10-03T20:37:18Z

Started test build 70848

flathubbot · 2023-10-03T20:58:33Z

Build 70848 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/53502/org.gnome.Totem.flatpakref

hadess · 2023-10-16T08:31:48Z

I was certain that I commented here when the PR was posted, but it seems I didn't. Any packaging updates like module or runtime upgrades need to go through the repo at https://github.com/flathub/org.gnome.Totem.Devel

I've cherry-picked the changes in this PR to flathub/org.gnome.Totem.Devel#24

A6GibKm · 2023-10-16T09:38:14Z

Is anyone testing the Devel package?

hadess · 2023-10-16T11:41:03Z

Is anyone testing the Devel package?

I do. It's also the package we recommend testing if the stable release isn't working as we've removed the nightlies from the GNOME servers.

A6GibKm · 2023-10-27T21:43:15Z

Some syslogs from running the app

oct 27 23:40:59 thinkpad systemd[2043]: Started dbus-:1.2-org.gnome.Totem.dleyna\x2dserver@11.service.
oct 27 23:40:59 thinkpad systemd[2043]: Started dbus-:1.2-org.gnome.Totem.Tracker3.Miner.Files@6.service.
oct 27 23:40:59 thinkpad systemd[2043]: Started app-flatpak-org.gnome.Totem-586019.scope.
oct 27 23:40:59 thinkpad systemd[2043]: Started app-flatpak-org.gnome.Totem-586027.scope.
oct 27 23:40:59 thinkpad systemd[2043]: dbus-:1.2-org.gnome.Totem.dleyna\x2dserver@11.service: Main process exited, code=exited, status=1/FAILURE
oct 27 23:40:59 thinkpad systemd[2043]: dbus-:1.2-org.gnome.Totem.dleyna\x2dserver@11.service: Failed with result 'exit-code'.
oct 27 23:40:59 thinkpad systemd[2043]: Started dbus-:1.2-org.gnome.Totem.dleyna\x2dserver@12.service.

oct 27 23:39:55 thinkpad tracker-extract[585844]: Could not create extraction controller: Cannot invoke method; proxy is for the well-known name org.freedesktop.Tracker3.Miner.Files without an owner, and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag

hadess · 2023-11-20T09:06:45Z

Did you see the latest two commits (2d8c908, 7566bde) added here? That fixes it on my end.

Unfortunately, those aren't fixes we can merge. They force the use of the host Tracker. Totem instead uses its own tracker instance that runs inside the container and doesn't leak data outside.

ssssam · 2023-11-21T12:50:32Z

Hi @hadess - can you provide context here about the data leaks you expect to happen ? I've searched Tracker and Tracker Miners issue tracker for "leak" and turned up nothing relevant.

For context @A6GibKm asked me if I can help move this forward since I volunteer time towards helping maintain Tracker. I am not sure how to support though.

A6GibKm · 2024-01-14T18:10:18Z

Is it preferable to block this PR on a problem for which there is no public evidence yet, rather using a runtime which is still supported? GNOME 43 was marked as EOL on September of last year.

I think it would be better to open an issue, all the other Tracker consumers are using the version in their system and it might be a good idea to fix this so everyone benefits from it.

julianfairfax · 2024-01-29T14:20:40Z

Is it preferable to block this PR on a problem for which there is no public evidence yet, rather using a runtime which is still supported?

No.

GNOME 43 was marked as EOL on September of last year.

This PR should be merged.

hadess · 2024-01-29T15:26:56Z

Is it preferable to block this PR on a problem for which there is no public evidence yet,

This is a repeat issue that the upstream tracker maintainers just forget about each time I mention it. I have very very very limited time to work on totem, and this sort of issue and the endless need to have to justify the maintenance of my own software just drains my energy. So you'll have to wait a bit more I'm afraid.

ssssam · 2024-01-29T16:51:48Z

If you write it down somewhere we might not forget.

marcthe12 · 2024-03-21T17:00:43Z

As Gnome 46 has been released, has this been solved with gnome 46 runtime? Maybe we should try gnome 46 update?

flathubbot · 2024-03-23T09:19:34Z

Started test build 109294

A6GibKm · 2024-03-23T09:22:28Z

Continuing this long standing tradition of sending a PR to update totem every cycle here is the latest iteration.

Since Flathub has strict checks for app metainfo nowadays older stable versions of the app won't build anymore and I used the current HEAD of upstream which contains the required patches. I could also backport them if thats more desirable.

As Gnome 46 has been released, has this been solved with gnome 46 runtime? Maybe we should try gnome 46 update?

I don't see any issue upstream to follow, hence there is nothing to solve.

EDIT: Actually 43.0 should pass appdata verification.

flathubbot · 2024-03-23T09:32:11Z

Build 109294 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/92123/org.gnome.Totem.flatpakref

flathubbot · 2024-03-23T10:05:21Z

Started test build 109305

flathubbot · 2024-03-23T10:18:31Z

Build 109305 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/92134/org.gnome.Totem.flatpakref

See https://gitlab.gnome.org/GNOME/totem/-/commit/a30c83deb82d738eb9d3d2b91636169aafb0ff80

flathubbot · 2024-03-23T22:27:38Z

Started test build 109443

A6GibKm · 2024-03-23T22:29:31Z

Small update, I was able to add back Tracker.

The problem now is that the videos don't have thumbnails. But this is also a problem in the current stable version. Using the Tracker from host fixes this.

flathubbot · 2024-03-23T22:45:17Z

Build 109443 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/92274/org.gnome.Totem.flatpakref

julianfairfax · 2024-05-30T08:26:39Z

@hadess Any chance this could be merged? GNOME Videos is a Core app and shouldn't use a GNOME Platform version that's 3 versions out-of-date and hasn't been supported for 9 months.

AsciiWolf · 2024-10-22T13:32:25Z

I agree with Julian. Totem is (still) a core GNOME app and as such would deserve a little better care.

Also, its last release was more than two years ago (see this ticket - fortunately the Flathub version is more recent).

This is not great and I hope that at least a new upstream version will get released until Totem gets probably replaced by something more suitable as a core app.

hadess · 2024-10-22T14:12:41Z

This is not great

Feel free to tell my employer who removed all the time I had to work on this software...

hadess

I'd like to see an attempt at figuring out what the problem is with the thumbnailing, as it seems to be working fine for me.

I will also note that the usual process for updating this repo is to update what needs to be updating in https://github.com/flathub/org.gnome.Totem.Devel/ and then cherry-picking those changes into the stable branch.

hadess · 2024-10-22T14:16:08Z

org.gnome.Totem.json

@@ -335,7 +335,6 @@
        {
            "name": "totem",
            "buildsystem": "meson",
-            "config-opts": ["-Denable-easy-codec-installation=no"],


The build option isn't obsolete in the version of the software that's still in this file. The config option should be removed when the software is updated to the version that removes it. It's also still supported in the latest stable branch, so this commit should be dropped.

hadess · 2024-10-22T14:20:34Z

org.gnome.Totem.json

@@ -1,7 +1,7 @@
 {
    "app-id": "org.gnome.Totem",
    "runtime": "org.gnome.Platform",
-    "runtime-version": "43",
+    "runtime-version": "45",


The runtime version change should be a separate commit.

hadess · 2024-10-22T14:22:17Z

dleyna/dleyna.json

@@ -12,7 +12,8 @@
        {
            "type": "git",
            "url": "https://gitlab.gnome.org/World/dLeyna.git",
-            "commit": "db67c3071af7d708a66ac6f13c31b052078955b2"


Please split the "DLNA" module updates from the gnome-desktop one.

hadess · 2024-10-22T14:22:38Z

dleyna/gssdp.json

-            "commit": "6eeaf27aec6ff11f325ff633b52bd56dbc1435aa",
-            "tag": "gssdp-1.6.0"
+            "commit": "c2d417d6a79f03c095e5730efd60015eb3109a82",
+            "tag": "gssdp-1.6.2"


Please squash this into the "DLNA" modules update.

hadess · 2024-10-22T14:23:16Z

dleyna/gupnp-av.json

@@ -5,8 +5,7 @@
        {
            "type": "git",
            "url": "https://gitlab.gnome.org/GNOME/gupnp-av.git",
-            "commit": "86f148ebb920a8113190fd3e6cae636c9fdd3ca7",
-            "tag": "gupnp-av-0.14.1"
+            "commit": "4da2f88f891883f52a40ff92432119a6083167cb"


Please squash this into the "DLNA" module update commit, while keeping the commit message.

hadess · 2024-10-22T14:25:17Z

codecs/ffmpeg.json

@@ -49,8 +49,12 @@
            "type": "git",
            "url": "https://git.ffmpeg.org/ffmpeg.git",
            /* Don't forget to update gst-libav-stop-caching-codecs.patch */
-            "tag": "n5.0",
-            "commit": "390d6853d0ef408007feb39c0040682c81c02751"
+            "tag": "n5.0.3",


Commit message says 5.0.2.

hadess · 2024-10-22T14:25:56Z

org.gnome.Totem.json

                "-Dsystemd_user_services=false"
            ],
            "sources": [
                {
                    "type": "git",
                    "url": "https://gitlab.gnome.org/GNOME/tracker.git",
-                    "tag": "3.6.0"
+                    "tag": "3.7.0"


This should be squashed into the earlier tracker update commit.

hadess · 2024-10-22T14:26:48Z

org.gnome.Totem.json

@@ -219,6 +219,7 @@
                "-Dsystemd_user_services=false",
                "-Dwriteback=false",
                "-Dbattery_detection=none",
+                "-Dlandlock=disabled",


This can be squashed into the tracker update commit as well, please keep the reference in the commit though.

hadess · 2024-10-22T14:27:20Z

org.gnome.Totem.json

@@ -229,7 +229,7 @@
                {
                    "type": "git",
                    "url": "https://gitlab.gnome.org/GNOME/tracker-miners.git",
-                    "tag": "3.6.1"
+                    "tag": "3.7.0"


This can probably go into the earlier tracker update commit.

hadess · 2024-10-22T14:27:34Z

org.gnome.Totem.json

-                    "commit": "26816b74a29b9d2d8dc169ed2f9649a4a159bc7c",
-                    "tag": "0.4"
+                    "commit": "de52f4fe1d317258f9c8f386d9ab82f03ac3a4fb",
+                    "tag": "0.5.0"


Maybe the gnome-desktop update should be in this commit.

AsciiWolf · 2024-10-22T14:54:56Z

Feel free to tell my employer who removed all the time I had to work on this software...

Yeah, I read that blog post and it is... Sad. :-/

Anyway, you can still try to allocate at least a little part of your free time to community work on basic things (like tagging a new version at least once a year or two - especially if most of the changes are already tested by the Flathub build). Or at least try to find a new maintainer - this also applies to this Flatpak.

I would love to help, however my time is probably even worse than yours. And I already maintain 30+ Flatpaks, contribute to countless Free Software projects and translate the whole GNOME desktop into Czech (because every other Czech translator gave up) - all in my free time.

hadess · 2024-10-22T15:21:10Z

Anyway, you can still try to allocate at least a little part of your free time to community work on basic things (like tagging a new version at least once a year or two - especially if most of the changes are already tested by the Flathub build). Or at least try to find a new maintainer - this also applies to this Flatpak.

I would love to help, however my time is probably even worse than yours. And I already maintain 30+ Flatpaks, contribute to countless Free Software projects and translate the whole GNOME desktop into Czech (because every other Czech translator gave up) - all in my free time.

I hope it's still fun for you because it really isn't for me. Especially when I read stuff like this that makes demands on what I should do in my free time. I haven't seen anyone contribute in any meaningful way to totem in years, so I'm not sure how I could find a new maintainer in this circumstance.

Anyway, this patchset is reviewed.

AsciiWolf · 2024-10-22T19:26:31Z

I hope it's still fun for you because it really isn't for me. Especially when I read stuff like this that makes demands on what I should do in my free time. I haven't seen anyone contribute in any meaningful way to totem in years, so I'm not sure how I could find a new maintainer in this circumstance.

Well, sometimes it's still fun, but sometimes it's far from it. But I feel that if I maintain some Free Software project or related stuff, I have certain responsibilities towards the community and the Linux desktop as a whole. But yeah, I am also attempting to minimize the amount of things I'm working on and focus more on the things that are important and/or beneficial to me.

I certainly did not want my previous comment to sound like I was demanding something from you. I was just unhappy with the state of Totem as a whole and did suggest that if you do not have more time (or even paid work time) to work on Totem, occasionally allocating a small enough amount of an unpaid time to Totem and other community work could be a realistic idea and it would still greatly help the project.

Anyway, thanks for making the new (long-awaited :-)) Totem release and for reviewing this PR!

A6GibKm · 2024-10-22T20:58:09Z

@hadess I would like to personally apologize if my previous comments in this PR where abrasive in any way.

Regarding the PR itself, I have my plate full at the moment. If someone wants to work on it please do so, otherwise I will eventually pick it up, probably.

Thanks for the review!

A6GibKm added 3 commits October 3, 2023 16:02

Remove obsolete build option

43f9053

See https://gitlab.gnome.org/GNOME/totem/-/commit/b9f3ef5823d067d552444055a0e7ae3939dc5784

Update libpeas to 1.36.0

371a0a5

See https://gitlab.gnome.org/GNOME/totem/-/commit/72b21bdd269c33c4aaa93ebc48d88de0cfd1be10.

Update tracker-miners to 3.6.1

55240d2

See https://gitlab.gnome.org/GNOME/totem/-/commit/f6e3571adc090c018e68d9c1e55688f9b16f8176

A6GibKm requested a review from hadess October 3, 2023 15:22

bbhtt reviewed Oct 3, 2023

View reviewed changes

org.gnome.Totem.json Outdated Show resolved Hide resolved

A6GibKm force-pushed the 45 branch from 7533ddb to 4cd9b1b Compare October 3, 2023 19:37

A6GibKm force-pushed the 45 branch from 4cd9b1b to f6f4ff0 Compare October 3, 2023 19:47

A6GibKm added 9 commits October 3, 2023 22:35

Build libsoup-2.4 ourselves

ceba715

See https://gitlab.gnome.org/GNOME/totem/-/commit/2c0feda81c492d85d058bff1e45d0bcd4ff8104b.

Update tracker to 3.6.0

c663bb3

Update shared-modules

f40f03c

Update modules

569c67d

Update gssdp to 1.6.2

8383d70

Update libmediaart to 1.9.6

8a4d063

with-docs was removed.

Update gupnp-av

d215fcb

We need https://gitlab.gnome.org/GNOME/gupnp-av/-/commit/9557768121d54fdcedabe7544863515d6a813354 to build the library and it is not yet in any release.

Update ffmpeg to n5.0.2

cf8142a

See flathub/io.github.celluloid_player.Celluloid@6d6d341

Update PipeWire to 0.3.80

237ed84

A6GibKm force-pushed the 45 branch from f6f4ff0 to 237ed84 Compare October 3, 2023 20:36

A6GibKm changed the title ~~Update runtime to 45~~ Update runtime to 46 Mar 23, 2024

A6GibKm force-pushed the 45 branch from 7f5370d to 386e87d Compare March 23, 2024 10:05

A6GibKm added 3 commits March 23, 2024 23:26

Update tracker to 3.7.0

721f896

Work-around tracker-miners build option problem

a360a39

See https://gitlab.gnome.org/GNOME/totem/-/commit/a30c83deb82d738eb9d3d2b91636169aafb0ff80

Update runtime to 46

59cf65e

A6GibKm force-pushed the 45 branch from 386e87d to 59cf65e Compare March 23, 2024 22:27

julianfairfax mentioned this pull request May 30, 2024

Update to GNOME Platform 47 (based on #104) #107

Closed

hadess requested changes Oct 22, 2024

View reviewed changes

Update runtime to 46 #104

Are you sure you want to change the base?

Update runtime to 46 #104

Conversation

A6GibKm commented Oct 3, 2023 • edited Loading

flathubbot commented Oct 3, 2023

flathubbot commented Oct 3, 2023

A6GibKm commented Oct 3, 2023

flathubbot commented Oct 3, 2023

flathubbot commented Oct 3, 2023

flathubbot commented Oct 3, 2023

flathubbot commented Oct 3, 2023

flathubbot commented Oct 3, 2023

flathubbot commented Oct 3, 2023

hadess commented Oct 16, 2023

A6GibKm commented Oct 16, 2023

hadess commented Oct 16, 2023

A6GibKm commented Oct 27, 2023

hadess commented Nov 20, 2023

ssssam commented Nov 21, 2023

A6GibKm commented Jan 14, 2024 • edited Loading

julianfairfax commented Jan 29, 2024

hadess commented Jan 29, 2024

ssssam commented Jan 29, 2024 • edited Loading

marcthe12 commented Mar 21, 2024

flathubbot commented Mar 23, 2024

A6GibKm commented Mar 23, 2024 • edited Loading

flathubbot commented Mar 23, 2024

flathubbot commented Mar 23, 2024

flathubbot commented Mar 23, 2024

flathubbot commented Mar 23, 2024

A6GibKm commented Mar 23, 2024

flathubbot commented Mar 23, 2024

julianfairfax commented May 30, 2024

AsciiWolf commented Oct 22, 2024 • edited Loading

hadess commented Oct 22, 2024

hadess left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AsciiWolf commented Oct 22, 2024

hadess commented Oct 22, 2024

AsciiWolf commented Oct 22, 2024 • edited Loading

A6GibKm commented Oct 22, 2024 • edited Loading

A6GibKm commented Oct 3, 2023 •

edited

Loading

A6GibKm commented Jan 14, 2024 •

edited

Loading

ssssam commented Jan 29, 2024 •

edited

Loading

A6GibKm commented Mar 23, 2024 •

edited

Loading

AsciiWolf commented Oct 22, 2024 •

edited

Loading

AsciiWolf commented Oct 22, 2024 •

edited

Loading

A6GibKm commented Oct 22, 2024 •

edited

Loading