Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runtime to 46 #104

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
72 changes: 72 additions & 0 deletions codecs/ffmpeg-binutils.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
From: Rémi Denis-Courmont <remi@remlab.net>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. Can you please file an issue to update to a newer ffmpeg major version against:
https://github.com/flathub/org.gnome.Totem.Devel/issues

You can reference this commit:
https://lwn.net/Articles/992496/

Date: Sun, 16 Jul 2023 15:18:02 +0000 (+0300)
Subject: avcodec/x86/mathops: clip constants used with shift instructions within inline assembly
X-Git-Url: https://git.videolan.org/?p=ffmpeg.git;a=commitdiff_plain;h=effadce6c756247ea8bae32dc13bb3e6f464f0eb

avcodec/x86/mathops: clip constants used with shift instructions within inline assembly

Fixes assembling with binutil as >= 2.41

Signed-off-by: James Almer <jamrial@gmail.com>
---

diff --git a/libavcodec/x86/mathops.h b/libavcodec/x86/mathops.h
index 6298f5ed19..ca7e2dffc1 100644
--- a/libavcodec/x86/mathops.h
+++ b/libavcodec/x86/mathops.h
@@ -35,12 +35,20 @@
static av_always_inline av_const int MULL(int a, int b, unsigned shift)
{
int rt, dummy;
+ if (__builtin_constant_p(shift))
__asm__ (
"imull %3 \n\t"
"shrdl %4, %%edx, %%eax \n\t"
:"=a"(rt), "=d"(dummy)
- :"a"(a), "rm"(b), "ci"((uint8_t)shift)
+ :"a"(a), "rm"(b), "i"(shift & 0x1F)
);
+ else
+ __asm__ (
+ "imull %3 \n\t"
+ "shrdl %4, %%edx, %%eax \n\t"
+ :"=a"(rt), "=d"(dummy)
+ :"a"(a), "rm"(b), "c"((uint8_t)shift)
+ );
return rt;
}

@@ -113,19 +121,31 @@ __asm__ volatile(\
// avoid +32 for shift optimization (gcc should do that ...)
#define NEG_SSR32 NEG_SSR32
static inline int32_t NEG_SSR32( int32_t a, int8_t s){
+ if (__builtin_constant_p(s))
__asm__ ("sarl %1, %0\n\t"
: "+r" (a)
- : "ic" ((uint8_t)(-s))
+ : "i" (-s & 0x1F)
);
+ else
+ __asm__ ("sarl %1, %0\n\t"
+ : "+r" (a)
+ : "c" ((uint8_t)(-s))
+ );
return a;
}

#define NEG_USR32 NEG_USR32
static inline uint32_t NEG_USR32(uint32_t a, int8_t s){
+ if (__builtin_constant_p(s))
__asm__ ("shrl %1, %0\n\t"
: "+r" (a)
- : "ic" ((uint8_t)(-s))
+ : "i" (-s & 0x1F)
);
+ else
+ __asm__ ("shrl %1, %0\n\t"
+ : "+r" (a)
+ : "c" ((uint8_t)(-s))
+ );
return a;
}

8 changes: 6 additions & 2 deletions codecs/ffmpeg.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,12 @@
"type": "git",
"url": "https://git.ffmpeg.org/ffmpeg.git",
/* Don't forget to update gst-libav-stop-caching-codecs.patch */
"tag": "n5.0",
"commit": "390d6853d0ef408007feb39c0040682c81c02751"
"tag": "n5.0.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message says 5.0.2.

"commit": "0e15444aceca0e78f99f3d67758eb79d11b86599"
},
{
"type": "patch",
"path": "ffmpeg-binutils.patch"
}
]
}
4 changes: 2 additions & 2 deletions codecs/pipewire.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
{
"type": "git",
"url": "https://gitlab.freedesktop.org/pipewire/pipewire.git",
"tag": "0.3.58",
"commit": "64a3edf89ec07957107dff984f053f41ded443fe"
"tag": "0.3.80",
"commit": "35cca08d2bef14248ac25ff2a1efb0bf274d0a6f"
}
]
}
3 changes: 2 additions & 1 deletion dleyna/dleyna.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/World/dLeyna.git",
"commit": "db67c3071af7d708a66ac6f13c31b052078955b2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the "DLNA" module updates from the gnome-desktop one.

"tag": "v0.8.3",
"commit": "69e5fd6d6314d3987e7b68c8150397cf626950fb"
}
]
}
9 changes: 7 additions & 2 deletions dleyna/gssdp.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
{
"name": "gssdp",
"buildsystem": "meson",
"config-opts" : [
"-Dexamples=false",
"-Dmanpages=false",
"-Dgtk_doc=false"
],
"sources": [
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/gssdp.git",
"commit": "6eeaf27aec6ff11f325ff633b52bd56dbc1435aa",
"tag": "gssdp-1.6.0"
"commit": "c2d417d6a79f03c095e5730efd60015eb3109a82",
"tag": "gssdp-1.6.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash this into the "DLNA" modules update.

}
]
}
3 changes: 1 addition & 2 deletions dleyna/gupnp-av.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/gupnp-av.git",
"commit": "86f148ebb920a8113190fd3e6cae636c9fdd3ca7",
"tag": "gupnp-av-0.14.1"
"commit": "4da2f88f891883f52a40ff92432119a6083167cb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash this into the "DLNA" module update commit, while keeping the commit message.

}
]
}
4 changes: 2 additions & 2 deletions dleyna/gupnp.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/gupnp.git",
"commit": "f05648e240c99be32911fb0c6de84e5954470e56",
"tag": "gupnp-1.6.0"
"commit": "04fc6512bcf26a405ede293592bd69c733f3191b",
"tag": "gupnp-1.6.5"
}
]
}
44 changes: 24 additions & 20 deletions org.gnome.Totem.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"app-id": "org.gnome.Totem",
"runtime": "org.gnome.Platform",
"runtime-version": "43",
"runtime-version": "46",
"sdk": "org.gnome.Sdk",
"command": "totem",
"finish-args": [
Expand Down Expand Up @@ -69,6 +69,7 @@
"cleanup": [ "/include", "/share/bash-completion", "/share/doc", "/lib/*.la" ],
"modules": [
"shared-modules/lua5.4/lua-5.4.json",
"shared-modules/libsoup/libsoup-2.4.json",
"codecs/liba52.json",
"codecs/libmpeg2.json",
"codecs/libdvdcss.json",
Expand All @@ -81,12 +82,13 @@
{
"name": "libpeas",
"buildsystem": "meson",
"config-opts": [ "-Dlua51=false" ],
"sources": [
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/libpeas.git",
"commit": "6b4217e0a5ec451cdbe9380df26d701d8e6bdf88",
"tag": "libpeas-1.26.0"
"commit": "7f245fa5158204621c3469756a951b68a651c4fe",
"tag": "libpeas-1.36.0"
}
]
},
Expand Down Expand Up @@ -119,7 +121,7 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/grilo.git",
"commit": "c80ca32b214a3c91ea1aed552d1a3b538c4b58c5"
"tag": "grilo-0.3.16"
}
],
"cleanup": [ "/include" ]
Expand All @@ -145,8 +147,8 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/gnome-online-accounts.git",
"commit": "a0931a8253e09e18768270f97b5e093e9df82fa8",
"tag": "3.36.0"
"commit": "05a2dc771e6645cb60ff3a9352af91e9572ce976",
"tag": "3.50.0"
}
]
},
Expand All @@ -170,8 +172,8 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/libgdata.git",
"commit": "6fd85102e7dcf7414000264a263465ba5cb894e4",
"tag": "0.17.12"
"commit": "eb7db048e5445ad567817dced344c47a20c6ea6b",
"tag": "0.18.1"
}
]
},
Expand All @@ -183,8 +185,8 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/gom.git",
"commit": "26816b74a29b9d2d8dc169ed2f9649a4a159bc7c",
"tag": "0.4"
"commit": "de52f4fe1d317258f9c8f386d9ab82f03ac3a4fb",
"tag": "0.5.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the gnome-desktop update should be in this commit.

}
]
},
Expand All @@ -195,13 +197,14 @@
"config-opts" : [
"-Ddocs=false",
"-Dman=false",
"-Dsoup=soup2",
"-Dsystemd_user_services=false"
],
"sources": [
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/tracker.git",
"tag": "3.4.1"
"tag": "3.7.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be squashed into the earlier tracker update commit.

}
]
},
Expand All @@ -215,6 +218,8 @@
"-Dminer_rss=false",
"-Dsystemd_user_services=false",
"-Dwriteback=false",
"-Dbattery_detection=none",
"-Dlandlock=disabled",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be squashed into the tracker update commit as well, please keep the reference in the commit though.

"-Ddomain_prefix=org.gnome.Totem",
"-Dminer_fs_cache_location=$XDG_CACHE_HOME/totem/miner/files",
"-Ddefault_index_recursive_dirs=['&VIDEOS']",
Expand All @@ -224,21 +229,21 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/tracker-miners.git",
"tag": "3.4.1"
"tag": "3.7.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably go into the earlier tracker update commit.

}
]
},
{
"name": "libmediaart",
"cleanup": [ "/bin", "/etc", "/libexec" ],
"buildsystem": "meson",
"config-opts": [ "-Dimage_library=gdk-pixbuf", "-Dwith-docs=no" ],
"config-opts": [ "-Dimage_library=gdk-pixbuf" ],
"sources": [
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/libmediaart.git",
"commit": "b14a5ce2dff52201aaed869fec03af49534c6475",
"tag": "1.9.4"
"commit": "69b4176bccb8032180fd8d48bb8b035c60acd203",
"tag": "1.9.6"
}
]
},
Expand Down Expand Up @@ -302,7 +307,7 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/grilo-plugins.git",
"commit": "b1a36383f63a895a505ca411d364d5e263bea013"
"tag": "grilo-plugins-0.3.16"
}
],
"cleanup": [ "/include" ]
Expand All @@ -314,7 +319,7 @@
{
"type": "git",
"url": "https://github.com/flatpak/flatpak-xdg-utils.git",
"tag": "1.0.4"
"tag": "1.0.5"
}
]
},
Expand All @@ -327,15 +332,14 @@
{
"type": "git",
"url": "https://gitlab.gnome.org/GNOME/gnome-desktop.git",
"commit": "b6112c345181d8e1509c443f97b4f8b7bcc61725",
"tag": "43"
"commit": "97c0344b3ba955bb6f6fe74ca03cc399a81acaa5",
"tag": "44.0"
}
]
},
{
"name": "totem",
"buildsystem": "meson",
"config-opts": ["-Denable-easy-codec-installation=no"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build option isn't obsolete in the version of the software that's still in this file. The config option should be removed when the software is updated to the version that removes it. It's also still supported in the latest stable branch, so this commit should be dropped.

"sources": [
{
"type": "git",
Expand Down