Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove cmake minium version deprecation warning #354

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: remove cmake minium version deprecation warning #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Requires `libfranka` >= 0.8.0
* `franka_description`: `<xacro:franka_robot/>` macro now supports to customize the `parent` frame and its `xyz` + `rpy` offset
* `franka_hw`: Fix the bug where the previous controller is still running after switching the controller. ([#326](https://github.com/frankaemika/franka_ros/issues/326))
* `franka_gazebo`: Add `set_franka_model_configuration` service.
* Update minimum CMake version to 3.10 to remove deprecation warnings

## 0.10.1 - 2022-09-15

Expand Down
2 changes: 1 addition & 1 deletion franka_control/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_control)

set(CMAKE_CXX_STANDARD 14)
Expand Down
2 changes: 1 addition & 1 deletion franka_description/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_description)

find_package(catkin REQUIRED)
Expand Down
2 changes: 1 addition & 1 deletion franka_example_controllers/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_example_controllers)

set(CMAKE_BUILD_TYPE Release)
Expand Down
2 changes: 1 addition & 1 deletion franka_gazebo/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_gazebo)

execute_process(COMMAND uname -m
Expand Down
2 changes: 1 addition & 1 deletion franka_gripper/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_gripper)

set(CMAKE_CXX_STANDARD 14)
Expand Down
2 changes: 1 addition & 1 deletion franka_hw/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_hw)

set(CMAKE_CXX_STANDARD 14)
Expand Down
2 changes: 1 addition & 1 deletion franka_msgs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_msgs)

find_package(catkin REQUIRED COMPONENTS message_generation std_msgs sensor_msgs actionlib_msgs)
Expand Down
2 changes: 1 addition & 1 deletion franka_ros/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1.3)
cmake_minimum_required(VERSION 2.8.3)
project(franka_ros)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not updated to 3.10 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gollth, thanks for reviewing my PR! I got an error when I updated it to 3.10 since the ROS meta package specs currently require version 2.8.3 (see https://wiki.ros.org/catkin/package.xml#Metapackages and moveit/moveit#1619).

How to reproduce

  1. Checkout 22627ef#diff-64225d9dae606e899687341a27336f3cfff2889d702f52095a148a4e6d50cb24 or change the CMake version in the franka_ros/CMakeLists.txt file to VERSION 3.10.
  2. Use catkin_make to build the package.
  3. Be greeted by the following error:
WARNING: The CMakeLists.txt of the metapackage 'franka_ros' contains non standard content. Use the content of the following file instead: /home/ricks/development/work/franka_ros_ws/build/catkin_generated/metapackages/franka_ros/CMakeLists.txt

Note

Catkin-tools doesn't have this problem.

find_package(catkin REQUIRED)
catkin_metapackage()
2 changes: 1 addition & 1 deletion franka_visualization/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.4)
cmake_minimum_required(VERSION 3.10)
project(franka_visualization)

set(CMAKE_CXX_STANDARD 14)
Expand Down
Loading