Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-abstract Limelight subsystem #154

Merged
merged 2 commits into from
Mar 20, 2024
Merged

re-abstract Limelight subsystem #154

merged 2 commits into from
Mar 20, 2024

Conversation

willitcode
Copy link
Member

Closes #145. Also deleted a random comment that was auto-generated by WPILib. Uses the given Limelight's mDNS name (derived from the NetworkTables name) to grab the CameraServer stream and push it up to Shuffleboard. Also specifies which Limelight it's talking about in the limelightHasTarget Shuffleboard entry.

Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine enough to me

Copy link
Member

@quackitsquinn quackitsquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willitcode willitcode merged commit e7851bb into main Mar 20, 2024
2 checks passed
@willitcode willitcode deleted the limelight-constants branch March 20, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limelight subsystem constants & abstraction
3 participants