Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-abstract Limelight subsystem #154

Merged
merged 2 commits into from
Mar 20, 2024
Merged

re-abstract Limelight subsystem #154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95475fa
re-abstract Limelight subsystem
willitcode Mar 19, 2024
169a1ee
Merge branch 'main' into limelight-constants
willitcode Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/main/java/frc/robot/subsystems/Limelight.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,11 @@ public Limelight(String name) {
.subscribe(defaultBotpos);

Shuffleboard.getTab("Driver")
.add(SendableCameraWrapper.wrap("Limelight", "http://10.9.37.5:5800/stream.mjpg"))
.add(SendableCameraWrapper.wrap(name, "http://" + name + ".local:5800/stream.mjpg"))
.withSize(4, 4);

/* TODO: CONSTANTS */
limelightHasTarget =
Shuffleboard.getTab("Driver").add("limelight has target", false).getEntry();
limelightHasTarget = Shuffleboard.getTab("Driver").add(name + "has target", false).getEntry();
}

/* now its time for getter method chaingun, which I have to write manually because VS Code */
Expand Down Expand Up @@ -165,8 +164,6 @@ public void setLimelightPipeline(double pipeline) {
/** Subsystem periodic; runs every scheduler run. */
@Override
public void periodic() {
// This method will be called once per scheduler run

limelightHasTarget.setBoolean(hasValidTarget());
}
}
Loading