Intake #17
Merged
Intake #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added INTAKE_MOTOR_ID with a temp value of 0.
Assigned intake object motor id from constants
Added INTAKE_MOTOR_SPEED with a temp value of 0.5
Added RunIntake() method and its contents run the motor
Added intake.runIntake() and intake.stop() to their respective methods.
Closed
quackitsquinn
previously approved these changes
Jan 23, 2024
willitcode
requested changes
Jan 24, 2024
Added INTAKE_LIMIT_SWITCH_DIO_PORT to constants.
Added limitSwitch object to Intake
Added getIntakeLimitSwitch() which returns the value of the limit switch for intake.
From getIntakeLimitSwitch() to getLimitSwitch()
RunIntake isFinished() returns the value of the intake's limit switch
Changed it from a Spark object to a CANSparkMax object.
willitcode
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can press the A button to run the intake. (intake motor speed may need to be flipped, but that's for later)