-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intake #17
Intake #17
Conversation
Added INTAKE_MOTOR_ID with a temp value of 0.
Assigned intake object motor id from constants
Added INTAKE_MOTOR_SPEED with a temp value of 0.5
Added RunIntake() method and its contents run the motor
Added intake.runIntake() and intake.stop() to their respective methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you for documenting everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See individual code comments.
Added INTAKE_LIMIT_SWITCH_DIO_PORT to constants.
Added limitSwitch object to Intake
Added getIntakeLimitSwitch() which returns the value of the limit switch for intake.
From getIntakeLimitSwitch() to getLimitSwitch()
RunIntake isFinished() returns the value of the intake's limit switch
Changed it from a Spark object to a CANSparkMax object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks! Sorry about all the change-request chaos.
You can press the A button to run the intake. (intake motor speed may need to be flipped, but that's for later)