Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKC 2024 Changes (Disaster) #179

Merged
merged 60 commits into from
May 19, 2024
Merged

GKC 2024 Changes (Disaster) #179

merged 60 commits into from
May 19, 2024

Conversation

willitcode
Copy link
Member

Mega-PR for all changes from GKC 2024. Changes:

  • Give our relays the correct IDs
  • Make taxi shorter so that (hopefully) we stop getting fouls for nudging the note that is pre-staged in front of us
  • Limelight mount offsets done (closes Limelight Offsets #168)
  • Limelight got a little bit tuned and changed, but still doesn't work
  • An LED was physically chopped off the robot because it decided it was a UFO and floated off the strip. We decreased the number of LEDs by one.
  • Shortened compressor deadband because it was too long and we weren't reaching the right pressure(s)
  • LOTS of autos, most are either untested or only somewhat tested
    • Limelight-less one piece auto (85% confidence this one works)
    • Long taxi (99% confidence)
    • Drive to center
      • Drives to the center line, but doesn't pick up a note
      • Too long, need to test distance
      • Works
    • Pick up note from center
      • Drives to center line while intaking to pick up a note
      • Too long, need to test distance
      • Works
  • Heading snapping steering with the analog stick was broken, so we just... got rid of heading snapping
    • We do need to change this a bit
  • Actually stopped the drivetrain in heading-snapping end() method
  • Moved the follow call for the belt motors
    • This doesn't actually change anything and should probably be reverted

willitcode and others added 30 commits April 4, 2024 09:29
technically unnecessary but w/e

Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
This reverts commit 0caf91d.
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Co-Authored-By: Gabe <91231142+willitcode@users.noreply.github.com>
Copy link
Member

@quackitsquinn quackitsquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) last pr of the school year

quackitsquinn
quackitsquinn previously approved these changes May 13, 2024
Copy link
Member

@quackitsquinn quackitsquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) last pr of the school year

Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sowwywywywywy

src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I paused my game to be here (it made me cringe to say that)

src/main/java/frc/robot/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
Copy link
Member

@AraReighard AraReighard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willitcode willitcode merged commit 654df60 into main May 19, 2024
2 checks passed
@willitcode willitcode deleted the gkc-2024 branch May 19, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limelight Offsets
5 participants