Improvements for finitely presented groups and homomorphisms #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
added
kind: enhancement
hulpke
force-pushed
the
fixes
branch
3 times, most recently
from
a457e14
to
6d3e5ab
Compare
hulpke
added
release notes: not needed
wilfwilson
reviewed
Jul 14, 2023
wilfwilson
approved these changes
Jul 16, 2023
Force size computation on certain permutation groups before constructing homomorphisms. This what the group order canbe used to help with constructing the homomorphism stabilizer chain.
Storing all pairs to be considered in the KB can end up very memory intensive, once a few hundred rules are reached. Instead store these pairs in more compact format. This also helps when rules get deleted. Also added are minor hooks to test for the fellow-travelling property.
simpler code, and force normal form on quotient if it is infinite. Delete rows of zeroes in relator matrix, but do not delete the whole matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance Improvements to the KB and abelian quotients of fp groups. Included is some size forcing for permutation homomorphisms