Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link.hh: add Sensor accessor APIs #2693

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Link.hh: add Sensor accessor APIs #2693

merged 2 commits into from
Dec 8, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Dec 6, 2024

🎉 New feature

Adds missing APIs

Summary

This adds SensorByName, Sensors, and SensorCount accessors to the Link class.

Test it

  1. Build this branch
  2. Run UNIT_Link_TEST
  3. Run INTEGRATION_link

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Link.hh: add Sensor accessor APIs
3ef40ee 
This adds SensorByName, Sensors, and SensorCount accessors
to the Link class.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from mjcarroll as a code owner December 6, 2024 19:04
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Dec 6, 2024
arjo129
arjo129 approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be worth updating the python bindings as well or opening a ticket to remind ourselves.

@scpeters
Add python bindings for new methods
43df8ba 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

scpeters commented Dec 7, 2024

LGTM. Might be worth updating the python bindings as well or opening a ticket to remind ourselves.

added python bindings in 43df8ba

@scpeters scpeters merged commit 7f002d6 into gz-sim9 Dec 8, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/link_sensor_methods_9 branch December 8, 2024 04:46
@scpeters
Copy link
Member Author

scpeters commented Dec 8, 2024

https://github.com/Mergifyio backport gz-sim8

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 8, 2024 •
edited
Loading

backport gz-sim8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 8, 2024
@scpeters @mergify
Link.hh: add Sensor accessor APIs (#2693)
6c9901b 
This adds SensorByName, Sensors, and SensorCount accessors
to the Link class with associated python bindings.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7f002d6)
@mergify mergify bot mentioned this pull request Dec 8, 2024
Merged
9 tasks
scpeters added a commit that referenced this pull request Dec 8, 2024
@scpeters
Link.hh: add Sensor accessor APIs (#2693)
1db0c27 
This adds SensorByName, Sensors, and SensorCount accessors
to the Link class with associated python bindings.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7f002d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@arjo129 arjo129 arjo129 approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @arjo129 @iche033