Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend shapes gui plugin width to include the ellipsoid button #2699

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Extend shapes gui plugin width to include the ellipsoid button #2699

merged 1 commit into from
Dec 13, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 12, 2024

🦟 Bug fix

Summary

The shapes gui plugin in gui config was not wide enough to show the ellipsoid tool button. So updated the gui config to reveal the button.

Before:

shapes_gui_width_before

After:

shapes_gui_width

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033
Extend shapes plugin width to include the ellipsoid button
d7e1fcf 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from jennuine as a code owner December 12, 2024 23:29
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Dec 12, 2024
@iche033 iche033 mentioned this pull request Dec 12, 2024
Merged
@iche033 iche033 merged commit f0cde05 into gz-sim9 Dec 13, 2024
11 checks passed
@iche033 iche033 deleted the shapes_width branch December 13, 2024 15:37
@iche033
Copy link
Contributor Author

iche033 commented Dec 13, 2024

@Mergifyio backport gz-sim8

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

backport gz-sim8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@iche033 @mergify
Extend shapes plugin width to include the ellipsoid button (#2699)
1572fb7 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit f0cde05)
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
8 tasks
iche033 added a commit that referenced this pull request Dec 13, 2024
@iche033
Extend shapes plugin width to include the ellipsoid button (#2699)
779b009 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit f0cde05)
@iche033 iche033 mentioned this pull request Dec 18, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @ahcorde