This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
feat: Remove DDM #1315
Merged
feat: Remove DDM #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shellmayr
reviewed
Jun 21, 2024
| @@ -6,8 +6,7 @@ sidebar_order: 13 | |||
| Sentry supports the emission of pre-aggregated metrics information via the `statsd` | |||
| envelope item. This emission bypasses relay-side sampling and assumes a client side | |||
| aggregator. In the product these are referred to as "custom metrics" and internally | |||
| the system sometimes carries the name "ddm" ([delightful developer | |||
| metrics](/delightful-developer-metrics/)). The functionality sits on top of the | |||
| the system sometimes carries the name "DDM". The functionality sits on top of the | |||
There was a problem hiding this comment.
nit: Is there a reason for keeping this around when any documentation of DDM is removed?
There was a problem hiding this comment.
Yeah, I thought about it. Some people still internally use word DDM and these docs are used for both internal and external readers so I figured there's no harm in keeping it to explain that this is actually what's known as DDM. No strong opinions though, this section might get removed completely as we move to the new spans world.
shellmayr
approved these changes
Jun 21, 2024
vgrozdanic
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
Sentry Developer Metricssection as most of it is already available on docs.sentry.io in a more up-to-date version. Some parts there were still relevant has been moved to other parts of the develop docs (metrics abstraction).Closes getsentry/sentry#71971