Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

feat: Remove DDM #1315

Merged
merged 1 commit into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/components/sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,6 @@ export default () => {
<SidebarLink to="/dynamic-sampling/" title="Dynamic Sampling">
<Children tree={tree.find(n => n.name === 'dynamic-sampling').children} />
</SidebarLink>
<SidebarLink
to="/delightful-developer-metrics/"
title="Sentry Developer Metrics"
>
<Children
tree={tree.find(n => n.name === 'delightful-developer-metrics').children}
/>
</SidebarLink>
</ul>
</li>
<li className="mb-3" data-sidebar-branch>
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
40 changes: 0 additions & 40 deletions src/docs/delightful-developer-metrics/index.mdx

This file was deleted.

This file was deleted.

146 changes: 0 additions & 146 deletions src/docs/delightful-developer-metrics/sending-metrics-sdk.mdx

This file was deleted.

40 changes: 0 additions & 40 deletions src/docs/delightful-developer-metrics/ui.mdx

This file was deleted.

3 changes: 1 addition & 2 deletions src/docs/sdk/metrics.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ sidebar_order: 13
Sentry supports the emission of pre-aggregated metrics information via the `statsd`
envelope item. This emission bypasses relay-side sampling and assumes a client side
aggregator. In the product these are referred to as "custom metrics" and internally
the system sometimes carries the name "ddm" ([delightful developer
metrics](/delightful-developer-metrics/)). The functionality sits on top of the
the system sometimes carries the name "DDM". The functionality sits on top of the
Copy link
Member

@shellmayr shellmayr Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is there a reason for keeping this around when any documentation of DDM is removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought about it. Some people still internally use word DDM and these docs are used for both internal and external readers so I figured there's no harm in keeping it to explain that this is actually what's known as DDM. No strong opinions though, this section might get removed completely as we move to the new spans world.

generics metrics platform which is also used for span and transaction level
metrics.

Expand Down
Loading
Loading