-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend line directive to copied source files and add test #10
Conversation
path string | ||
want string | ||
}{ | ||
{filepath.Join(testdata, "src", "a", "a.go"), "//line src/a/a.go:1"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference from #9 is that the path is not absolute (does not have /
prefix).
I finished implementing what I wanted to accomplish with this pull request. |
@tenntenn |
testdata/src/a/go.mod
Outdated
@@ -0,0 +1,3 @@ | |||
module a | |||
|
|||
go 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go 1.21と書くとgo 1.21rc2が含まれてしまうので、go 1.21.0の方が良いかもです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tenntenn
ありがとうございます!修正しました!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @tenntenn and @usatie!
I tried to go ahead with the implementation to append the line directive.
Added a simple test and also responded to @tenntenn's suggestion.
I look forward to gostaticanalysis/testutil being further refined 🚀