Prepend line directive to copied source files and add test #10
+79
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1LoW
commented
Sep 26, 2023
| path string | ||
| want string | ||
| }{ | ||
| {filepath.Join(testdata, "src", "a", "a.go"), "//line src/a/a.go:1"}, |
There was a problem hiding this comment.
The difference from #9 is that the path is not absolute (does not have / prefix).
|
I finished implementing what I wanted to accomplish with this pull request. |
|
@tenntenn |
tenntenn
reviewed
Dec 3, 2023
testdata/src/a/go.mod
Outdated
| @@ -0,0 +1,3 @@ | |||
| module a | |||
|
|
|||
| go 1.21 | |||
There was a problem hiding this comment.
go 1.21と書くとgo 1.21rc2が含まれてしまうので、go 1.21.0の方が良いかもです。
There was a problem hiding this comment.
@tenntenn
ありがとうございます！修正しました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tenntenn and @usatie!
I tried to go ahead with the implementation to append the line directive.
Added a simple test and also responded to @tenntenn's suggestion.
I look forward to gostaticanalysis/testutil being further refined 🚀