-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend line directive to copied source files and add test #10
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f152afd
Prepend line directive to copied source files
usatie 5354e05
Add test
k1LoW c8af8a7
Use filepath.Ext()
k1LoW 615dea5
Use filepath.Rel() instead of strings.TrimPrefix() to get relative path
k1LoW 3f5a2d4
More error information
k1LoW 23cd192
Prepend line directive to temp .go files using *os.File (io.ReadWrite…
k1LoW bb4411c
Request only the stable versions
k1LoW File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package testutil | ||
|
||
import ( | ||
"os" | ||
"path/filepath" | ||
"testing" | ||
|
||
"golang.org/x/tools/go/analysis/analysistest" | ||
) | ||
|
||
func TestWithModules(t *testing.T) { | ||
t.Parallel() | ||
|
||
t.Run("The line directive is appended to the go source codes", func(t *testing.T) { | ||
testdata := WithModules(t, analysistest.TestData(), nil) | ||
tests := []struct { | ||
path string | ||
want string | ||
}{ | ||
{filepath.Join(testdata, "src", "a", "a.go"), "//line src/a/a.go:1"}, | ||
{filepath.Join(testdata, "src", "a", "b", "b.go"), "//line src/a/b/b.go:1"}, | ||
} | ||
for _, tt := range tests { | ||
b, err := os.ReadFile(tt.path) | ||
if err != nil { | ||
t.Fatal(err) | ||
} | ||
if got := string(b[:len(tt.want)]); got != tt.want { | ||
t.Errorf("got %q, want %q", got, tt.want) | ||
} | ||
} | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
package a | ||
|
||
func a() { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
package b | ||
|
||
func b() { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module a | ||
|
||
go 1.21 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. go 1.21と書くとgo 1.21rc2が含まれてしまうので、go 1.21.0の方が良いかもです。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tenntenn |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference from #9 is that the path is not absolute (does not have
/
prefix).