Fix Vulnerability Breaking Changes in Docs #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nathannaveen
commented
Sep 30, 2024
nathannaveen
commented
- This PR was created because of Search for Vulns via Artifact guac#2153
✅ Deploy Preview for resonant-wisp-1a517a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
funnelfiasco
requested changes
Sep 30, 2024
There was a problem hiding this comment.
My read of guacsec/guac#2153 indicates that the types added here were added in the wrong place.
Minor nit, but I wouldn't quote the types since they don't contain any characters that the shell might otherwise try to interpret. Quoting them doesn't change behavior, but it's not the typical style.
* This PR was created because of guacsec/guac#2153 Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
nathannaveen
force-pushed
the
nathan/updateDocsForVulnChanges
branch
from
3f39e49
to
c4297a5
Compare
|
I marked this as draft so that we won't merge it until the corresponded code is merged and released. Thanks for doing this, @nathannaveen! |
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
|
@funnelfiasco the PR guacsec/guac#2153 has been merged in, and guac v0.8.9 has been released, so can we merge this in so that we can update guac.sh with these changes? Thanks! |
funnelfiasco
added a commit
to funnelfiasco/guac-docs
that referenced
this pull request
Oct 7, 2024
This is due to changes introduced in guacsec#150 Signed-off-by: Ben Cotton <ben@kusari.dev>
abhirajadhikary06
pushed a commit
to abhirajadhikary06/guac-docs
that referenced
this pull request
Oct 30, 2024
This is due to changes introduced in guacsec#150 Signed-off-by: Ben Cotton <ben@kusari.dev> Signed-off-by: Abhiraj Adhikary <abhirajadhikary06@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.