Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for Vulns via Artifact #2153

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

With the hasSBOM nodes being attached to artifacts as well as packages, we have to also search hasSBOM nodes via artifacts as well as packages to find vuln nodes.

This PR includes the functionality to search for vuln nodes via artifacts in addition to our already implemented functionality to search via packages.

Feature change:

  • With this PR, the user has to include the input type (purl, uri, artifact) when searching for vulns. This is because the user can now pass in an artifact, a purl, or a uri into the query. But, trying to understand the input is very complicated process, so leaving it as the user input is probably the best solution for now instead of us trying to guess the inputs type.
  • I will create a PR for guac-docs regarding this so that the demos use commands that have the types passed in.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
nathannaveen added a commit to nathannaveen/guac-docs that referenced this pull request Sep 30, 2024
* This PR was created because of guacsec/guac#2153

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
nathannaveen added a commit to nathannaveen/guac-docs that referenced this pull request Sep 30, 2024
* This PR was created because of guacsec/guac#2153

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kodiakhq kodiakhq bot merged commit e39fb22 into guacsec:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants