Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encodings #255

Closed
wants to merge 136 commits into from
Closed

Encodings #255

wants to merge 136 commits into from

Conversation

bdestombe
Copy link
Collaborator

No description provided.

dbrakenhoff and others added 30 commits June 16, 2023 11:13
@dbrakenhoff
improve get_geotop
2c918b4 
- use chunks and dask delayed to keep memory usage efficient
- get_geotop now gets raw data
- add deprecationwarning to get_geotop_raw_within_extent()
@dbrakenhoff
old get_geotop is renamed geotop_to_layermodel:
456b983 
- now takes geotop_ds as input to convert to layers (not extent)
@dbrakenhoff
clean up old code
84593ce
@dbrakenhoff
improve get_regis:
62a9861 
- do not use sortby but check diff of y dimension and flip if necessary
@dbrakenhoff
add cache support for chunked datasets
56a264e
@dbrakenhoff
add log msg to split_layers
68a4c1f
@OnnoEbbens
remove nan layer (value -127) from geo_eenheden
4ed3976
@dbrakenhoff
use values instead of data to deal with potential dask array
25f4f72
@dbrakenhoff
improve geotop:
f9cc9d7 
- use .values instead of .data to load data into memory if using dask
- undo onno changes for now w missing strat code
@dbrakenhoff
if caching with dask, close and reopen ds to ensure ds points to file
34dfdcf
@dbrakenhoff
Use dask delayed to read model output
5376c19 
- add kwarg delayed, if False, load data into memory, else return data array with delayed dask arrays
- add kwarg chunked, if True, chunk data array with chunks="auto"
- add x,y data to vertex grid data array
@dbrakenhoff
add delayed, chunked kwargs to output methods
2179557
@dbrakenhoff
fix DeprecationWarning
de54e3d
@dbrakenhoff
improve log messages grid.py
5618671
@dbrakenhoff
replace modflow with mf6 in logging
758f87d
@dbrakenhoff
replace modflow with mf6 in logging
a70974a
@dbrakenhoff
more info in log message
5044c04 
- add function name in all cases
- add line number when level is DEBUG
@dbrakenhoff
docstrings
c6c1aa3
@dbrakenhoff
fix tests
87e7afe
@dbrakenhoff
fix geotop_lithok_in_cross_section
a6a26c5 
- use .values to deal with dask arrays
- use get_geotop
- update docstring
@rubencalje
Rename geotop_to_layermodel to to_model_layers and remove convert_geo…
471e724 
…top_to_ml_layers
@rubencalje
Some minor changes
26db2e8
@rubencalje
Fix combination of regis and geotop
a551f55
@OnnoEbbens
version bump
b4b5256
@rubencalje
Improve geotop.to_model_layers and add method insert_layer
fd588c7
@rubencalje
Add extra legends for layer models
776a654 
Add
@rubencalje
Add Formatie van Nieuwkoop, Laagpakket van Nij Beets in geotop
ecbe766
@OnnoEbbens
shorten name model_dataset_created_on -> created_on
4fba381
@OnnoEbbens @rubencalje
199 nlmodgwfic slow for uniform starting head (#200)
62eadc9 
* fix for #199

* fix

* return da in some situations

---------

Co-authored-by: Ruben Caljé <r.calje@artesia-water.nl>
@rubencalje
Update webservices.py
961f321 
Small fix for Error: Assigning CRS to a GeoDataFrame without a geometry column is not supported
rubencalje and others added 29 commits August 25, 2023 10:00
@rubencalje
Add caching for DataArrays as well
f4c40f7
@dbrakenhoff
codacy, pass on fmt_base kwarg
8839d06 
black formatting
@rubencalje
Fix bug found by tests
959d436
@rubencalje
Update test_006_caching.py
7ce393e
@rubencalje
Remove last empty cell again
5d52ce2
@dbrakenhoff
codacy suggestions
47d3de2
@dbrakenhoff
rename backgroundmap to background everywhere
4fa08c8
@dbrakenhoff
Merge pull request #244 from ArtesiaWater/plotting-in-notebooks
8ecca8a 
improve plotting in notebooks #224
@dbrakenhoff
Merge pull request #241 from ArtesiaWater/epsg-28992-issue
c73f524 
fix Projection issue in backgroundmaps #240
@dbrakenhoff
Merge pull request #243 from ArtesiaWater/stop_overwriting_kh_and_kv_…
3e61b49 
…geotop

Stop overwriting kh and kv of geotop in add_geotop_to_regis_layers
@OnnoEbbens
Make write_and_run more consistent, #233
d5b8f70
@OnnoEbbens
remove all the unnecessary references on top of the modules
51f6853
@OnnoEbbens
Merge branch 'dev' of github.com:ArtesiaWater/nlmod into dev
1961dfd
@dbrakenhoff
codacy fix
c9ad917
@dbrakenhoff
codacy fix
b25a209
@rubencalje
Add docstring to _check_for_data_array
46ccfbb
@dbrakenhoff
Merge pull request #248 from ArtesiaWater/codacy
9161091 
codacy suggestions
@dbrakenhoff
improve gwf bc pkgs
f4ef09b 
- add RIV pkg #97
- fix mask checks in bc pkgs #213
- add check on dataarray coords #214
@rubencalje
Remove idomain from Dataset
4ddd093
@rubencalje
Add docstring to get_idomain
cec77d4
@rubencalje
Fix tests and rename "active" to "active_domain"
a9002da
@rubencalje
set idomain above/below the first/last active layer to 0
94198fc
@rubencalje
Merge pull request #247 from ArtesiaWater/add_caching_data_array
f3fa3ee 
Add caching for DataArrays as well
@rubencalje
Improve test for caching DataArrays
12175a3
@dbrakenhoff
Merge pull request #249 from ArtesiaWater/97-drn-riv-ghb-packages-in-…
5b8ccf0 
…nlmodgwf

improve gwf bc pkgs
@rubencalje
Change typo
a525f7d
@rubencalje
Merge pull request #250 from ArtesiaWater/calculate_idomain_on_the_fly
2030fda 
Remove idomain from Dataset
@bdestombe
Attributes encoding (#245)
dd9e478 
* Small doc changes to gwt/output.py

* Create attributes_encodings.py

* Removed unused imports

* Extended get_encodings

* Added test to encoding

* Minor indentation bug in get_encodings()

* Better error message in attributes encoding
@bdestombe
Not all encodings were returned
8d3d349
@bdestombe bdestombe closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdestombe @dbrakenhoff @OnnoEbbens @rubencalje