Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with display of Tools data on Homepage and Projects page #5321

Closed
5 tasks done
t-will-gillis opened this issue Aug 27, 2023 · 4 comments · Fixed by #5380
Closed
5 tasks done

Fix bug with display of Tools data on Homepage and Projects page #5321

t-will-gillis opened this issue Aug 27, 2023 · 4 comments · Fixed by #5380
Assignees
Labels
Bug Something isn't working Complexity: Medium P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented Aug 27, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

We want our website to demonstrate professionalism and attention to detail to our visitors. On the homepage and Projects page, a bug was recently introduced that removes the spaces between entries in the Tools data.

Screenshot of existing Tools data on project card, no spaces between entries

Screenshot 2023-08-28 195937

Action Items

  • Refer to current-projects.js, which is the code for the rendering of the project data on the two HfLA webpages.
  • Towards the end of the file, within the projectCardComponent() function, there is code to render the tools data when it exists.
    • The indentation of the <div class="project-tools"> needs to match the indentation of the other <div>s in this section.
    • The line which includes ${ project.tools } should be refactored in a similar fashion as for project.languages and project.technologies, so that a comma and a space are added between the each entry when joining the tools data into a list string
  • Confirm with Docker on your local repo that the Tools data renders as expected on the two webpages, and review and compare the rest of the pages to confirm that no other unexpected changes/ deletions/ etc. have been made.

Resources/Instructions

Hompage
Projects page
This issue was initiated by #5309

@t-will-gillis t-will-gillis added Bug Something isn't working role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe P-Feature: Home page https://www.hackforla.org/ Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.5pt Can be done in 3 hours or less labels Aug 27, 2023
@t-will-gillis t-will-gillis added this to the 03.02 Onboarding flow milestone Aug 27, 2023
@t-will-gillis t-will-gillis added Complexity: Medium and removed Ready for Prioritization Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Aug 29, 2023
@erinzz erinzz self-assigned this Aug 29, 2023
@github-actions

This comment was marked as outdated.

@t-will-gillis
Copy link
Member Author

Hello @erinzz I am unassigning you from this issue because you have not completed a Complexity: Small issue yet. There currently are small issues available on the Project Board.

@davidwiese davidwiese self-assigned this Aug 29, 2023
@github-actions
Copy link

Hi @davidwiese, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@davidwiese
Copy link
Member

Availability: August 30 12-4pm
ETA: August 31 4pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Medium P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

3 participants