HIP-584: Fix too low estimate values for auto account creation and contract create #6633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
IvanKavaldzhiev
added
bug
IvanKavaldzhiev
requested review from
stoyanov-st,
georgi-l95,
steven-sheehy,
0xivanov,
mustafauzunn,
kselveliev and
bilyana-gospodinova
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6633 +/- ##
============================================
- Coverage 92.56% 92.55% -0.01%
- Complexity 6506 6511 +5
============================================
Files 844 845 +1
Lines 27428 27458 +30
Branches 3138 3140 +2
============================================
+ Hits 25389 25415 +26
- Misses 1326 1329 +3
- Partials 713 714 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
georgi-l95
previously approved these changes
Aug 11, 2023
2 tasks
steven-sheehy
requested changes
Aug 14, 2023
...-web3/src/main/java/com/hedera/mirror/web3/evm/contracts/execution/MirrorEvmTxProcessor.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/test/resources/contracts/EthCall/EthCallInit.bin
Outdated
Show resolved
Hide resolved
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
…imate-values # Conflicts: # hedera-mirror-web3/src/test/java/com/hedera/mirror/web3/service/ContractCallTestSetup.java Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
IvanKavaldzhiev
added
limechain
|
Kudos, SonarCloud Quality Gate passed!
|
steven-sheehy
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently gas estimate for hollow account creation and contract creates is too low. This PR adds some missing logic and aligns gas calculator behaviour with services codebase.
Related issue(s):
Fixes #6620
Notes for reviewer:
Checklist