Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TopicMessageSubmitTransaction #447

Merged
merged 36 commits into from
Aug 10, 2023
Merged

Implement TopicMessageSubmitTransaction #447

merged 36 commits into from
Aug 10, 2023

Conversation

rwalworth
Copy link
Contributor

Description:
This PR implements the APIs associated with TopicMessageSubmitTransaction, which allows a user to submit a message on a topic.

Related issue(s):

Fixes #429

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth
Add TopicCreateTransaction
1919235 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
ecb3fb9
@rwalworth
Add TopicCreateTransaction unit tests
fed4f10 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicCreateTransaction integration tests | Add consensus service …
58c7c88 
…stub to Node

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicId
b7089df 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicId unit tests
be0e306 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicId to TransactionReceipt
72ae662 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
48d3311
@rwalworth
Merge branch 'main' into 00427-implement-topicid
99a9946
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
c01bd97
@rwalworth
Merge branch 'main' into 00427-implement-topicid
68d377f
@rwalworth
Merge branch 'main' into 00421-implement-topiccreatetransaction
19bf2de
@rwalworth
Merge branch 'main' into 00427-implement-topicid
3224370
@rwalworth
Add TopicDeleteTransaction
44a93a6 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00421-implement-topiccreatetransaction' into 00426-impl…
70ca341 
…ement-topicdeletetransaction

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicDeleteTransaction unit tests
03d0a16 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicDeleteTransaction integration tests
378d4fb 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Do TopicCreateTransaction TODOs
aaf61ee 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00427-implement-topicid' into 00428-implement-topicinfo…
9af149d 
…query
@rwalworth
Add TopicInfo and TopicInfoQuery
7350d35 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicInfo and TopicInfoQuery unit tests
13aff15 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00421-implement-topiccreatetransaction' into 00428-impl…
671f1fd 
…ement-topicinfoquery

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00426-implement-topicdeletetransaction' into 00428-impl…
ff25acf 
…ement-topicinfoquery

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicInfoQuery integration tests
926f4e3 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add to TopicCreateTransaction integration tests
1e3263a 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicUpdateTransaction
4dcef0d 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicUpdateTransaction unit tests
6af3eec 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00428-implement-topicinfoquery' into 00430-implement-to…
bf1fda3 
…picupdatetransaction

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicUpdateTransaction integration tests
44860c5 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00427-implement-topicid' into 00429-implement-topicmess…
87e0742 
…agesubmittransaction
@rwalworth
Add TopicMessageSubmitTransaction | Add createChunk() to ChunkedTrans…
0ea0709 
…action to facilitate additional functionality for derived classes when creating chunks

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicMessageSubmitTransaction unit tests
597891b 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch 'main' into 00429-implement-topicmessagesubmittransaction
c77e55f 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Merge branch '00430-implement-topicupdatetransaction' into 00429-impl…
9d2189f 
…ement-topicmessagesubmittransaction

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Add TopicMessageSubmitTransaction integration tests
f5e65ee 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Jul 25, 2023
@rwalworth rwalworth requested a review from deyanzz July 25, 2023 15:10
@rwalworth rwalworth self-assigned this Jul 25, 2023
@rwalworth rwalworth linked an issue Jul 25, 2023 that may be closed by this pull request
Implement TopicMessageSubmitTransaction #429
Closed
@deyanzz
Copy link
Contributor

deyanzz commented Aug 8, 2023 •
edited
Loading

To be able to finish the review, first we need to resolve the conflicts.

@rwalworth
Merge branch 'main' into 00429-implement-topicmessagesubmittransaction
a5839df 
Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth
Copy link
Contributor Author

To be able to finish the review, first we need to resolve the conflicts.

Conflicts resolved, this is good to review.

@rwalworth rwalworth mentioned this pull request Aug 9, 2023
Merged
2 tasks
deyanzz
deyanzz approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@deyanzz deyanzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Created the following issue in the Java SDK to track missing tests:

Also, created the following issue to track missing integration tests in C++ SDK:

@deyanzz deyanzz merged commit b987b0c into main Aug 10, 2023
2 checks passed
@deyanzz deyanzz deleted the 00429-implement-topicmessagesubmittransaction branch August 10, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyanzz deyanzz deyanzz approved these changes

Assignees

@rwalworth rwalworth

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TopicMessageSubmitTransaction
2 participants
@rwalworth @deyanzz