Skip to content

Fix normalizeNode to keep text/inline nodes when removing blocks (#… #4018

Fix normalizeNode to keep text/inline nodes when removing blocks (#…

Fix normalizeNode to keep text/inline nodes when removing blocks (#… #4018

Triggered via push November 23, 2024 00:01
Status Success
Total duration 3m 29s
Artifacts

ci.yml

on: push
Matrix: ci
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 2 warnings, and 1 notice
[chromium] › integration/examples/markdown-shortcuts.test.ts:14:7 › On markdown-shortcuts example › can add list items: playwright/integration/examples/markdown-shortcuts.test.ts#L30
1) [chromium] › integration/examples/markdown-shortcuts.test.ts:14:7 › On markdown-shortcuts example › can add list items Error: Timed out 8000ms waiting for expect(locator).toHaveCount(expected) Locator: locator('ul > li') Expected: 3 Received: 0 Call log: - expect.toHaveCount with timeout 8000ms - waiting for locator('ul > li') - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" - locator resolved to 0 elements - unexpected value "0" 28 | await page.keyboard.press('Backspace') 29 | > 30 | await expect(page.locator('ul > li')).toHaveCount(3) | ^ 31 | 32 | expect(await page.locator('ul > li').nth(0).innerText()).toContain( 33 | '1st Item' at /home/runner/work/slate/slate/playwright/integration/examples/markdown-shortcuts.test.ts:30:43
[firefox] › integration/examples/placeholder.test.ts:18:7 › placeholder example › renders editor tall enough to fit placeholder: playwright/integration/examples/placeholder.test.ts#L32
2) [firefox] › integration/examples/placeholder.test.ts:18:7 › placeholder example › renders editor tall enough to fit placeholder Error: expect(received).toBeGreaterThanOrEqual(expected) Expected: >= 83.19999694824219 Received: 22.399993896484375 30 | throw new Error('Could not get bounding box for placeholder') 31 | > 32 | expect(editorBoundingBox.height).toBeGreaterThanOrEqual( | ^ 33 | placeholderBoundingBox.height 34 | ) 35 | }) at /home/runner/work/slate/slate/playwright/integration/examples/placeholder.test.ts:32:38
Slow Test: [chromium] › integration/examples/markdown-shortcuts.test.ts#L1
[chromium] › integration/examples/markdown-shortcuts.test.ts took 16.4s
Slow Test: [chromium] › integration/examples/code-highlighting.test.ts#L1
[chromium] › integration/examples/code-highlighting.test.ts took 15.2s
🎭 Playwright Run Summary
2 flaky [chromium] › integration/examples/markdown-shortcuts.test.ts:14:7 › On markdown-shortcuts example › can add list items [firefox] › integration/examples/placeholder.test.ts:18:7 › placeholder example › renders editor tall enough to fit placeholder 2 skipped 74 passed (1.7m)