Remove xfails from in-tree onnx op test config. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Todd <scott.todd0@gmail.com>
Signed-off-by: Scott Todd <scott.todd0@gmail.com>
ScottTodd
force-pushed
the
onnx-xfail-ignore
branch
from
a61f460
to
a6c7845
Compare
ScottTodd
commented
Oct 24, 2024
| @@ -53,25 +54,31 @@ jobs: | |||
|
|
|||
| # Run tests and output new config files as needed. | |||
| - name: Run ONNX ops test suite | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
This workflow will rarely "fail" now. We might want some way to treat test failures as okay, but still report test runner failures (e.g. out of disk space, failed to download files, etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we won't need to update the xfails in this repository after nightly releases affect which tests are passing.
Downstream (iree-org/iree) will still use the xfail behavior, while this repository will just report the current status, including all logs for failures.
This also now uploads a HTML report for each run to github actions artifacts. We could host these reports on github pages for easier viewing too.