Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xfails from in-tree onnx op test config. #35

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Remove xfails from in-tree onnx op test config. #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5744137
Remove xfails from in-tree onnx op test config.
ScottTodd Oct 24, 2024
a6c7845
Generate html report for onnx op tests.
ScottTodd Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/test_onnx_ops.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
env:
VENV_DIR: ${{ github.workspace }}/.venv
CONFIG_FILE_PATH: onnx_ops/configs/onnx_ops_cpu_llvm_sync.json
HTML_REPORT_PATH: onnx_ops/onnx_ops_test_report_cpu_llvm_sync.html
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand All @@ -53,25 +54,31 @@ jobs:

# Run tests and output new config files as needed.
- name: Run ONNX ops test suite
continue-on-error: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow will rarely "fail" now. We might want some way to treat test failures as okay, but still report test runner failures (e.g. out of disk space, failed to download files, etc.).

run: |
source ${VENV_DIR}/bin/activate
pytest onnx_ops/ \
-n auto \
-rA \
--timeout=30 \
--durations=10 \
--html=${HTML_REPORT_PATH} \
--self-contained-html \
--report-log=/tmp/onnx_ops_cpu_logs.json \
--config-files=${CONFIG_FILE_PATH}
- name: Upload HTML report
uses: actions/upload-artifact@v4
with:
name: onnx_ops_test_report_cpu_llvm_sync.html
path: ${{ env.HTML_REPORT_PATH }}
- name: Update config file with latest XFAIL lists
if: failure()
run: |
source ${VENV_DIR}/bin/activate
python onnx_ops/update_config_xfails.py \
--log-file=/tmp/onnx_ops_cpu_logs.json \
--config-file=${CONFIG_FILE_PATH}
cat ${CONFIG_FILE_PATH}
- name: Upload new config file
if: failure()
uses: actions/upload-artifact@v4
with:
name: onnx_ops_cpu_llvm_sync.json
Expand Down
Loading
Loading