Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes post Python 3.12 support #7020

Merged
merged 1 commit into from
Oct 22, 2024
Merged

CI fixes post Python 3.12 support #7020

merged 1 commit into from
Oct 22, 2024

Conversation

ssheorey
Copy link
Member

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Remaining changes left over from the Python 3.12 support PR.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

  • Do not build Tensorflow ops for Python 3.8 on macOS. TF doesn't support Python 3.8 anymore.
  • FetchContent_Populate -> FetchContent_MakeAvailable (cmake deprecation)
  • Clearer compiler error on macOS for building the viewer app with the C++ file (Use the .mm file instead).

Copy link

update-docs bot commented Oct 22, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Copy link
Member Author

Minor PR. Merging without review.

@ssheorey ssheorey merged commit e89d210 into main Oct 22, 2024
41 of 45 checks passed
@ssheorey ssheorey deleted the ss/misc branch October 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant