Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes post Python 3.12 support #7020

Merged
merged 1 commit into from
Oct 22, 2024
Merged

CI fixes post Python 3.12 support #7020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ jobs:

env:
BUILD_CUDA_MODULE: OFF
# TensorFlow v2.16 does not support Python 3.8
BUILD_TENSORFLOW_OPS: ${{ matrix.python_version == '3.8' && 'OFF' || 'ON' }}
OPEN3D_ML_ROOT: ${{ github.workspace }}/Open3D-ML
steps:
- name: Checkout source code
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ubuntu-wheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ jobs:
uses: actions/checkout@v4
with:
repository: isl-org/Open3D-ML
ref: ss/python-3.12 # remove before merge
path: ${{ env.OPEN3D_ML_ROOT }}
- name: Download wheels
uses: actions/download-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion 3rdparty/googletest/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ FetchContent_Declare(
INSTALL_COMMAND ""
)

FetchContent_Populate(ext_googletest)
FetchContent_MakeAvailable(ext_googletest)
FetchContent_GetProperties(ext_googletest SOURCE_DIR GOOGLETEST_SOURCE_DIR)
10 changes: 2 additions & 8 deletions cpp/pybind/t/geometry/lineset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,20 +257,16 @@ transformation as :math:`P = R(P) + t`)");

Args:
angle (float): The rotation angle in degree.

axis (open3d.core.Tensor): The rotation axis.

resolution (int): The resolution defines the number of intermediate sweeps
about the rotation axis.

translation (float): The translation along the rotation axis.

Returns:
A triangle mesh with the result of the sweep operation.


Example:

This code generates a spring from a single line::

import open3d as o3d
Expand All @@ -286,18 +282,16 @@ transformation as :math:`P = R(P) + t`)");
R"(Sweeps the line set along a direction vector.

Args:

vector (open3d.core.Tensor): The direction vector.

scale (float): Scalar factor which essentially scales the direction vector.

Returns:
A triangle mesh with the result of the sweep operation.


Example:

This code generates an L-shaped mesh::

import open3d as o3d

lines = o3d.t.geometry.LineSet([[1.0,0.0,0.0],[0,0,0],[0,0,1]], [[0,1],[1,2]])
Expand Down Expand Up @@ -326,7 +320,7 @@ matrices. Camera reference frame is shown with XYZ axes in RGB.

Example:

Draw a purple camera frame with XYZ axes in RGB.
Draw a purple camera frame with XYZ axes in RGB::

import open3d.core as o3c
from open3d.t.geometry import LineSet
Expand Down
Loading