Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: set recommend model to undefined if no model available #4296

Merged
merged 2 commits into from
Dec 19, 2024
Merged

enhancement: set recommend model to undefined if no model available #4296

merged 2 commits into from
Dec 19, 2024
+7 −4

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 19, 2024

Describe Your Changes

  • set recommend model to undefined when model.length === 0

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur requested a review from louis-jan December 19, 2024 05:59
@urmauur urmauur added the type: enhancement Improves a current feature label Dec 19, 2024
@urmauur urmauur added this to the v0.5.12 milestone Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.05%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/hooks/useCreateNewThread.ts44, 46, 51-52, 55-56, 163-164, 166-167, 174-175, 186, 195, 230, 233
web/hooks/useRecommendedModel.ts36, 51-52, 54-55, 58, 60-62, 67, 69-71, 75, 79-81, 84-85, 88, 91-92, 95
web/screens/Thread/ThreadCenterPanel/ChatInput/index.tsx81, 89, 95, 100, 113-117, 127-129, 134, 137, 163, 172, 178, 180, 245-247, 269-271, 300, 324, 376-378, 380-382, 384-386, 388-390, 403

@github-actions GitHub Actions
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 0271774 into dev Dec 19, 2024
21 checks passed
@urmauur urmauur deleted the enhance/update-flow-model-selector branch December 19, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@urmauur urmauur

Labels
type: enhancement Improves a current feature
Projects
None yet
Milestone
v0.5.12
Development

Successfully merging this pull request may close these issues.

feat: Prompt user to download model, if no models are available
2 participants
@urmauur @louis-jan