enhancement: set recommend model to undefined if no model available

web/hooks/useCreateNewThread.ts

@@ -23,6 +23,7 @@
 
 import { useActiveModel } from './useActiveModel'
 
+import useRecommendedModel from './useRecommendedModel'
 import useSetActiveThread from './useSetActiveThread'
 
 import { extensionManager } from '@/extension'
@@ -40,19 +41,19 @@
 
 const createNewThreadAtom = atom(null, (get, set, newThread: Thread) => {
   // create thread state for this new thread
   const currentState = { ...get(threadStatesAtom) }
 
   const threadState: ThreadState = {
     hasMore: false,
     waitingForResponse: false,
     lastMessage: undefined,
   }
   currentState[newThread.id] = threadState
   set(threadStatesAtom, currentState)
 
   // add the new thread on top of the thread list to the state
   const threads = get(threadsAtom)
   set(threadsAtom, [newThread, ...threads])
 })
 
 export const useCreateNewThread = () => {
@@ -73,6 +74,8 @@
   const threads = useAtomValue(threadsAtom)
   const { stopInference } = useActiveModel()
 
+  const { recommendedModel } = useRecommendedModel()
+
   const requestCreateNewThread = async (
     assistant: (ThreadAssistantInfo & { id: string; name: string }) | Assistant,
     model?: Model | undefined
@@ -81,7 +84,7 @@
     setIsGeneratingResponse(false)
     stopInference()
 
-    const defaultModel = model
+    const defaultModel = model || recommendedModel
 
     if (!model) {
       // if we have model, which means user wants to create new thread from Model hub. Allow them.
@@ -157,19 +160,19 @@
     //TODO: Why do we have thread list then thread states? Should combine them
     try {
       const createdThread = await persistNewThread(thread, assistantInfo)
       if (!createdThread) throw 'Thread created failed.'
       createNewThread(createdThread)
 
       setSelectedModel(defaultModel)
       setThreadModelParams(createdThread.id, {
         ...defaultModel?.settings,
         ...defaultModel?.parameters,
         ...overriddenSettings,
       })
 
       // Delete the file upload state
       setFileUpload(undefined)
       setActiveThread(createdThread)
     } catch (ex) {
       return toaster({
         title: 'Thread created failed.',
@@ -180,7 +183,7 @@
   }
 
   const updateThreadExtension = (thread: Thread) => {
     return extensionManager
       .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
       ?.modifyThread(thread)
   }
@@ -189,7 +192,7 @@
     threadId: string,
     assistant: ThreadAssistantInfo
   ) => {
     return extensionManager
       .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
       ?.modifyThreadAssistant(threadId, assistant)
   }
@@ -224,7 +227,7 @@
       .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
       ?.createThread(thread)
       .then(async (thread) => {
         await extensionManager
           .get<ConversationalExtension>(ExtensionTypeEnum.Conversational)
           ?.createThreadAssistant(thread.id, assistantInfo)
         return thread

web/hooks/useRecommendedModel.ts

@@ -67,6 +67,7 @@ export default function useRecommendedModel() {
     if (models.length === 0) {
       // if we have no downloaded models, then can't recommend anything
       console.debug("No downloaded models, can't recommend anything")
+      setRecommendedModel(undefined)
       return
     }
 

web/screens/Thread/ThreadCenterPanel/ChatInput/index.tsx

@@ -188,9 +188,8 @@ const ChatInput = () => {
               </Button>
             }
             disabled={
-              !isModelSupportRagAndTools &&
-              activeAssistant?.tools &&
-              activeAssistant?.tools[0]?.enabled
+              !isModelSupportRagAndTools ||
+              (activeAssistant?.tools && activeAssistant?.tools[0]?.enabled)
             }
             content={
               <>