Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make webhook url configurable #310

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lifeofguenter
Copy link

in certain setups we separate jenkins from private/public network. We do setup a reverse proxy though for webhooks from public to work. That however means that we need to let jenkins register the public url, instead of the private url.

Fortunately, this is already half-way supported (though most prolly for a different use case).

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the patch is fine but the PR title is misleading: -Djenkins.hook.url=https://the.proxy/ already works for register, just not for unregister.

rootUrl = Jenkins.get().getRootUrl();
}
if (rootUrl == null) {
return rootUrl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return rootUrl;
return null;

(for clarity)

@joseblas joseblas enabled auto-merge (squash) March 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants