Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ADA-1514): Incorrect focus order is observed when Related Files button is activated. #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tzipi-kaltura
Copy link
Contributor

Description of the Changes

Issue:
when we have more than one attachment/caption the focus move to the last item and not the first

Solution:
shouldFocus is sent as true to downloadItem only if this is the first item in the caption/attachment list and not for all item (and of course also only if this is the first list in the overlay)

improvement of #74

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants