Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase MaxNamespaceSkip in test runner #5722

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Increase MaxNamespaceSkip in test runner #5722

merged 1 commit into from
Sep 14, 2021

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 9, 2021

The error was:

test_runner.go:163: Couldn't initialize clients: unable to find available namespace

Changes tested in knative-extensions/eventing-kafka-broker#1227

Fixes #5700

Proposed Changes

  • Increase MaxNamespaceSkip in test runner

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

@pierDipi
Increase MaxNamespaceSkip in test runner
c47c13b 
```
test_runner.go:163: Couldn't initialize clients: unable to find available namespace
```
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021 •
edited
Loading

Codecov Report

Merging #5722 (c47c13b) into main (316e14d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5722   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         200      200           
  Lines        6261     6261           
=======================================
  Hits         5177     5177           
  Misses        750      750           
  Partials      334      334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316e14d...c47c13b. Read the comment docs.

@pierDipi
Copy link
Member Author

pierDipi commented Sep 9, 2021

/retest

matzew
matzew reviewed Sep 14, 2021
View reviewed changes
test/lib/test_runner.go
@@ -48,7 +48,7 @@ import (
const (
podLogsDir = "pod-logs"
testPullSecretName = "kn-eventing-test-pull-secret"
MaxNamespaceSkip = 50
MaxNamespaceSkip = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgencur any thoughts on this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good. We tested that in the PR knative-extensions/eventing-kafka-broker#1227 . Increasing the value will help in cases with high parallelization and a lot of tests. I don't see any drawback in this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matthias, Martin is ok with this change, see knative-extensions/eventing-kafka-broker#1227 (comment)

matzew
matzew approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 372e821 into main Sep 14, 2021
@pierDipi pierDipi deleted the hotfix/increase-MaxNamespaceSkip-test-runner branch September 15, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@mgencur mgencur Awaiting requested review from mgencur

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test runner: Couldn't initialize clients: unable to find available namespace
4 participants
@pierDipi @knative-prow-robot @matzew @mgencur