Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase MaxNamespaceSkip in test runner #5722

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Increase MaxNamespaceSkip in test runner #5722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/lib/test_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import (
const (
podLogsDir = "pod-logs"
testPullSecretName = "kn-eventing-test-pull-secret"
MaxNamespaceSkip = 50
MaxNamespaceSkip = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgencur any thoughts on this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good. We tested that in the PR knative-extensions/eventing-kafka-broker#1227 . Increasing the value will help in cases with high parallelization and a lot of tests. I don't see any drawback in this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matthias, Martin is ok with this change, see knative-extensions/eventing-kafka-broker#1227 (comment)

MaxRetries = 5
RetrySleepDuration = 2 * time.Second
)
Expand Down