Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.0] Allow probes to explicitly set the port to the containerPort (#8288) #12270

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #12225

Allow setting TCP and HTTP port to be equal to containerPort on readiness and liveness probes.

@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 12, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers labels Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #12270 (2806e02) into release-1.0 (f1e419a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.0   #12270      +/-   ##
===============================================
- Coverage        87.44%   87.41%   -0.03%     
===============================================
  Files              196      196              
  Lines             9614     9626      +12     
===============================================
+ Hits              8407     8415       +8     
- Misses             930      933       +3     
- Partials           277      278       +1     
Impacted Files Coverage Δ
pkg/apis/serving/fieldmask.go 95.07% <100.00%> (+0.03%) ⬆️
pkg/apis/serving/k8s_validation.go 93.50% <100.00%> (+0.19%) ⬆️
pkg/autoscaler/scaling/multiscaler.go 87.27% <0.00%> (-1.82%) ⬇️
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-1.54%) ⬇️
pkg/autoscaler/statforwarder/leases.go 75.53% <0.00%> (-1.44%) ⬇️
pkg/http/response_recorder.go 100.00% <0.00%> (ø)
pkg/reconciler/revision/background.go 93.20% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e419a...2806e02. Read the comment docs.

@dprotaso
Copy link
Member

/retest

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@dprotaso
Copy link
Member

/test pull-knative-serving-unit-tests

hmmm...

=== RUN   TestReconcileWithCollector 
metric_test.go:217: CreateOrUpdate() called 0 times, want non-zero times   
FAIL: TestReconcileWithCollector (5.27s)

@dprotaso
Copy link
Member

/retest

@knative-prow-robot knative-prow-robot merged commit 177aec6 into knative:release-1.0 Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants