Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ci e2e script for cert IDs #3392

Merged
merged 2 commits into from
Sep 26, 2023
Merged

update ci e2e script for cert IDs #3392

merged 2 commits into from
Sep 26, 2023

Conversation

oliviassss
Copy link
Collaborator

Issue

#3391

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2023
@oliviassss oliviassss added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (12124ad) 55.76% compared to head (07921a5) 55.76%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3392   +/-   ##
=======================================
  Coverage   55.76%   55.76%           
=======================================
  Files         149      149           
  Lines        8827     8827           
=======================================
  Hits         4922     4922           
  Misses       3571     3571           
  Partials      334      334

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliviassss
Copy link
Collaborator Author

/retest

1 similar comment
@oliviassss
Copy link
Collaborator Author

/retest

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2023
@oliviassss oliviassss mentioned this pull request Sep 24, 2023
Merged
6 tasks
@oliviassss
Copy link
Collaborator Author

Need to change the permission of the s3 bucket in the new account, will reach out to these with access to the new testing account
{"level":"error","ts":"2023-09-23T00:13:11Z","msg":"Reconciler error","controller":"service","object":{"name":"ip-e2e-tls","namespace":"service-ip-e2e-ac9f06"},"namespace":"service-ip-e2e-ac9f06","name":"ip-e2e-tls","reconcileID":"9299c3a7-0370-4c5e-af83-2618f050884e","error":"ValidationError: Access Denied for bucket: lb-controller-e2e-209411653980. Please check S3bucket permission\n\tstatus code: 400, request id: 206a0fb3-7f2c-49ba-ae32-ba61ca92d84a"}

@oliviassss
Copy link
Collaborator Author

/retest

@oliviassss oliviassss added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Sep 25, 2023
@M00nF1sh
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit e4e6d90 into kubernetes-sigs:main Sep 26, 2023
2 checks passed
@oliviassss oliviassss deleted the e2e-fix branch October 11, 2023 17:18
@oliviassss oliviassss mentioned this pull request Oct 20, 2023
Merged
6 tasks
shraddhabang pushed a commit to shraddhabang/aws-load-balancer-controller that referenced this pull request Oct 20, 2023
@oliviassss @shraddhabang
update ci e2e script for cert IDs (kubernetes-sigs#3392)
09f3a46 
* update ci e2e script for cert IDs

* add creation for s3 bucket
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
Pull request kubernetes-sigs#7: IENGOC-39: Remediate http/2 vulnerabi…
a622844 
…lity

Merge in DEL/aws-load-balancer-controller-fork from IENGOC-39 to main

* commit '3e26f86e82a5d419a7f8adfc5c95dd45984be6f4':
  IENGOC-39: Remediate more bd vulnerabilities
  IENGOC-39: Remediate bd vulnerabilities
  cut v2.6.2 release (kubernetes-sigs#3453)
  update ci e2e script for cert IDs (kubernetes-sigs#3392)
  fix test failure
  doc updates (kubernetes-sigs#3426)
  Change of text "your-cluster-name" (kubernetes-sigs#3152)
  slice init style suggestion
  whitespace
  group errors, emit one event per reconcile, requeue on failure
  don't block TGB reconciliation loop on failed SG ingress reconciliation
  fix: remove service from function args
  feat: resolve health check port name for NLB
  Expose ingress configuration options for missing backends (kubernetes-sigs#3342)
  Stricter dependency/security review
  remove unnecessary patch requests (kubernetes-sigs#3380)
  increase timeout to 2h in ci scripts
  wait for the TG to be healthy before cleanup any resource
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
@oliviassss @johngmyers
update ci e2e script for cert IDs (kubernetes-sigs#3392)
340a6ec 
* update ci e2e script for cert IDs

* add creation for s3 bucket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviassss @codecov-commenter @M00nF1sh @k8s-ci-robot