feat: create folder in the vfolder form item #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
force-pushed
the
feature/folder-creation-in-launchers
branch
from
482c9b5
to
84c69d2
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.1% (-0.01% 🔻) |
348/6822 |
| 🔴 | Branches | 4.65% (-0% 🔻) |
218/4690 |
| 🔴 | Functions | 2.97% (-0.01% 🔻) |
67/2253 |
| 🔴 | Lines | 5% (-0.01% 🔻) |
333/6664 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from b5244a5
Merge activity
|
 ## Changes This PR enhances the folder creation functionality and improves the VFolderTable component: 1. Updated `FolderCreateModal`: - Modified `onRequestClose` to accept an optional `FolderCreationResponse` parameter - Added `FolderCreationResponse` interface to define the structure of the created folder data - Updated `mutationToCreateFolder` to use the `FolderCreationResponse` type - Modified the `onSuccess` callback to pass the created folder data to `onRequestClose` 2. Enhanced `VFolderTable`: - Added a "Create Folder" button with a plus icon - Implemented a modal for creating new folders - Updated the table to refresh and select the newly created folder after creation - Added tooltips for the refresh and create folder buttons - Set the default sort order for the "Created" column to descending 3. Improved table functionality: - Added `sortDirections` prop to allow both ascending and descending sorting ## How to test - Create vFolder in Session Launcher and Service Launcher by clicking the "+" button on the top right of the vFolder Table form item. - You can see the created vFolder in the list with a selected status.
yomybaby
force-pushed
the
feature/folder-creation-in-launchers
branch
from
84c69d2
to
b5244a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR enhances the folder creation functionality and improves the VFolderTable component:
Updated
FolderCreateModal:onRequestCloseto accept an optionalFolderCreationResponseparameterFolderCreationResponseinterface to define the structure of the created folder datamutationToCreateFolderto use theFolderCreationResponsetypeonSuccesscallback to pass the created folder data toonRequestCloseEnhanced
VFolderTable:Improved table functionality:
sortDirectionsprop to allow both ascending and descending sortingHow to test