-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create folder in the vfolder form item #2765
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
482c9b5
to
84c69d2
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.1% (-0.01% 🔻) |
348/6822 |
🔴 | Branches | 4.65% (-0% 🔻) |
218/4690 |
🔴 | Functions | 2.97% (-0.01% 🔻) |
67/2253 |
🔴 | Lines | 5% (-0.01% 🔻) |
333/6664 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from b5244a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/b7260560-a79b-4fb3-9c20-f8f48866d892.png) ## Changes This PR enhances the folder creation functionality and improves the VFolderTable component: 1. Updated `FolderCreateModal`: - Modified `onRequestClose` to accept an optional `FolderCreationResponse` parameter - Added `FolderCreationResponse` interface to define the structure of the created folder data - Updated `mutationToCreateFolder` to use the `FolderCreationResponse` type - Modified the `onSuccess` callback to pass the created folder data to `onRequestClose` 2. Enhanced `VFolderTable`: - Added a "Create Folder" button with a plus icon - Implemented a modal for creating new folders - Updated the table to refresh and select the newly created folder after creation - Added tooltips for the refresh and create folder buttons - Set the default sort order for the "Created" column to descending 3. Improved table functionality: - Added `sortDirections` prop to allow both ascending and descending sorting ## How to test - Create vFolder in Session Launcher and Service Launcher by clicking the "+" button on the top right of the vFolder Table form item. - You can see the created vFolder in the list with a selected status.
84c69d2
to
b5244a5
Compare
Changes
This PR enhances the folder creation functionality and improves the VFolderTable component:
Updated
FolderCreateModal
:onRequestClose
to accept an optionalFolderCreationResponse
parameterFolderCreationResponse
interface to define the structure of the created folder datamutationToCreateFolder
to use theFolderCreationResponse
typeonSuccess
callback to pass the created folder data toonRequestClose
Enhanced
VFolderTable
:Improved table functionality:
sortDirections
prop to allow both ascending and descending sortingHow to test