Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create folder in the vfolder form item #2765

Merged
merged 1 commit into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. feat: create folder in the vfolder form item (#2765)

    ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/b7260560-a79b-4fb3-9c20-f8f48866d892.png)
    
    ## Changes
    
    This PR enhances the folder creation functionality and improves the VFolderTable component:
    
    1. Updated `FolderCreateModal`:
       - Modified `onRequestClose` to accept an optional `FolderCreationResponse` parameter
       - Added `FolderCreationResponse` interface to define the structure of the created folder data
       - Updated `mutationToCreateFolder` to use the `FolderCreationResponse` type
       - Modified the `onSuccess` callback to pass the created folder data to `onRequestClose`
    
    2. Enhanced `VFolderTable`:
       - Added a "Create Folder" button with a plus icon
       - Implemented a modal for creating new folders
       - Updated the table to refresh and select the newly created folder after creation
       - Added tooltips for the refresh and create folder buttons
       - Set the default sort order for the "Created" column to descending
    
    3. Improved table functionality:
       - Added `sortDirections` prop to allow both ascending and descending sorting
    
    ## How to test
    - Create vFolder in Session Launcher and Service Launcher by clicking the "+" button on the top right of the vFolder Table form item.
    - You can see the created vFolder in the list with a selected status.
    yomybaby committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b5244a5 View commit details
    Browse the repository at this point in the history