Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt configure to accept unconnected tf trees #931

Open
brunofavs opened this issue Apr 22, 2024 · 1 comment
Open

Adapt configure to accept unconnected tf trees #931

brunofavs opened this issue Apr 22, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request low priority To do if there are no other active issues

Comments

@brunofavs
Copy link
Collaborator

ATOM should look if all the chains between the estimated tf's and not the entire tree.

In zau there were multiple tf branches that we discarded but were bugging our configure.

if nx.is_weakly_connected(nx_graph):
print('Checking if TF tree is connected ... ', end='')
else:
pos = nx.random_layout(nx_graph)
edges, weights = zip(*nx.get_edge_attributes(nx_graph, 'weight').items())
# edge_labels = nx.draw_networkx_edge_labels(nx_graph, pos)
nx.draw(nx_graph, with_labels=True)
plt.show()
raise ValueError('TF tree is not connected. Aborting.')

@brunofavs brunofavs added the enhancement New feature or request label Apr 22, 2024
@miguelriemoliveira
Copy link
Member

This may have many implications. Will give it low priority for now...

@miguelriemoliveira miguelriemoliveira self-assigned this Apr 23, 2024
@miguelriemoliveira miguelriemoliveira added the low priority To do if there are no other active issues label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority To do if there are no other active issues
Development

No branches or pull requests

2 participants