Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent.c): wait for agent to successfully spawn before exiting. #694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awsomearvinder
Copy link

We open a pipe with the agent when we spawn it, and wait for them to say they're ready before exiting. This should fix #650.

The underlying issue was that when doing:

lpass login foo@example.com
lpass show bar

in a script would cause a race condition where lpass login exited before the agent was successfully brought up. lpass show bar then tried to reach out to the agent, sees the socket isn't created yet, and says the user isn't logged in.

@awsomearvinder
Copy link
Author

awsomearvinder commented Jul 17, 2024

Force pushed to add the Signed-Off-by required by the contributing guidelines.

We open a pipe with the agent when we spawn it, and wait for them
to say they're ready before exiting. This *should* fix lastpass#650.

The underlying issue was that when doing:
```
lpass login foo@example.com
lpass show bar
```
in a script would cause a race condition where `lpass login` exited
before the agent was successfully brought up. `lpass show bar` then
tried to reach out to the agent, sees the socket isn't created yet,
and says the user isn't logged in.

Signed-Off-by: Arvinder Dhanoa <ArvinderDhan@gmail.com>
@awsomearvinder
Copy link
Author

awsomearvinder commented Jul 29, 2024

@rui-rafael-lastpass Hi, apologies for the ping. I was wondering if / when this PR could potentially get reviewed? If possible I'd like to get this patch in for whenever your next release may be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random lpass Error: Could not find decryption key
1 participant