Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent.c): wait for agent to successfully spawn before exiting. #694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(agent.c): wait for agent to successfully spawn before exiting. #694

wants to merge 1 commit into from

Commits on Jul 19, 2024

  1. fix(agent.c): wait for agent to successfully spawn before exiting. 

    We open a pipe with the agent when we spawn it, and wait for them
to say they're ready before exiting. This *should* fix lastpass#650.

The underlying issue was that when doing:
```
lpass login foo@example.com
lpass show bar
```
in a script would cause a race condition where `lpass login` exited
before the agent was successfully brought up. `lpass show bar` then
tried to reach out to the agent, sees the socket isn't created yet,
and says the user isn't logged in.

Signed-Off-by: Arvinder Dhanoa <ArvinderDhan@gmail.com>
    @awsomearvinder
    awsomearvinder committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3d2baff View commit details
    Browse the repository at this point in the history