Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ltnews40 intro, corrections and some reordering #1512

Merged
merged 14 commits into from
Oct 29, 2024
Merged

Conversation

FrankMittelbach
Copy link
Member

@FrankMittelbach FrankMittelbach commented Oct 28, 2024

Internal housekeeping

Status of pull request

  • Feedback wanted
  • Ready to merge

Checklist of required changes before merge will be approved

  • [n/a] Test file(s) added
  • [n/a] Version and date string updated in changed source files
  • [n/a] Relevant \changes entries in source included
  • [n/a] Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

Looks like the ltugboat change hasn't yet made it to all mirrors, so at the moment the firstaid test file errors (after David's change to it). Not much that one can do about it other that wait, I guess.

Looks like the pull request ran through, so it is really an issue that will go away by tomorrow (hopefully).

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
Copy link
Contributor

@muzimuzhi muzimuzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo

Copy link
Member

@u-fischer u-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from two typos one comment:

This new feature can be disabled with \verb+\tagpdfsetup{math/mathml/luamml=false}+

This should change if the math-PR is merged/reviewed. To fit in the structure elements the key names have changed (this one still continues to work for now but is not documented). There is a summary section in latex-lab-math which tries to show all keys, and the examples show all main keys too.

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Show resolved Hide resolved
Copy link
Member

@davidcarlisle davidcarlisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos and rewordings done as code diff suggestions so they can be accepted (or not) on site

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
@FrankMittelbach
Copy link
Member Author

Looks good, apart from two typos one comment:

This new feature can be disabled with \verb+\tagpdfsetup{math/mathml/luamml=false}+

This should change if the math-PR is merged/reviewed. To fit in the structure elements the key names have changed (this one still continues to work for now but is not documented). There is a summary section in latex-lab-math which tries to show all keys, and the examples show all main keys too.

Then please provide me with a new text, as the math-PR assuming that the math-PR gets merged (which I think it should).

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
FrankMittelbach and others added 2 commits October 28, 2024 21:34
Co-authored-by: David Carlisle <d.p.carlisle@gmail.com>
Co-authored-by: Skillmon <Skillmon@users.noreply.github.com>
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
@muzimuzhi
Copy link
Contributor

muzimuzhi commented Oct 28, 2024

Test on required/latex-lab/testfiles-firstaid/test-ltugboat.{lvt,tlg} failed, probably caused by the just updated new version of (l)tugboat.cls.

Update: But for now, for unknown reason I cannot reproduce the .tlg update locally.

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
Copy link
Member

@josephwright josephwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minot typo-level suggestions

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
FrankMittelbach and others added 2 commits October 29, 2024 09:59
Co-authored-by: Joseph Wright <joseph@texdev.net>
@josephwright
Copy link
Member

We now good-to-go here?

@FrankMittelbach
Copy link
Member Author

We now good-to-go here?

@u-fischer suggested we should change one description once the latex-lab-math is merged (for that we need text) and and there is the question about use of "efficiencies" other than fine from my side.

@FrankMittelbach
Copy link
Member Author

We now good-to-go here?

@u-fischer suggested we should change one description once the latex-lab-math is merged (for that we need text) and and there is the question about use of "efficiencies" other than fine from my side.

ah I see you changedthe latter already.

@u-fischer
Copy link
Member

@u-fischer suggested we should change one description once the latex-lab-math is merged

I would suggest to say that the loading of luamml can be suppressed with math/mathml/luamml/load=false and that more options to configure the mathml tagging can be found in latex-lab-math.pdf.

@FrankMittelbach
Copy link
Member Author

@u-fischer suggested we should change one description once the latex-lab-math is merged

I would suggest to say that the loading of luamml can be suppressed with math/mathml/luamml/load=false and that more options to configure the mathml tagging can be found in latex-lab-math.pdf.

ok done

@josephwright josephwright merged commit f312ef0 into develop Oct 29, 2024
84 checks passed
@josephwright josephwright deleted the ltnews40 branch October 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants