chore: modify MonadStats
to not extend parents multiple times
#169
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonadStats was extending
MonadLiftT
twice, but the two parents were defeq. This was a hack to get around the fact that the parent instances were providingMonadLiftT
instances rather than aMonadLift
instance, breakingMonadLiftT
inference.This changes it to not extend
MonadLiftT
, instead embedding it as a field, and then writing an explicitMonadLift
instance. While it could still extend theMonadLiftT
instance, it is better this way because no one should be providingMonadLiftT
instances.This is motivated by lean4#5770, which will log warnings when structures extend parents multiple times.