Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify MonadStats to not extend parents multiple times #169

Merged
merged 1 commit into from
Oct 22, 2024

Commits on Oct 19, 2024

  1. chore: modify MonadStats to not extend parents multiple times

    MonadStats was extending `MonadLiftT` twice, but the two parents were defeq. This was a hack to get around the fact that the parent instances were providing `MonadLiftT` instances rather than a `MonadLift` instance, breaking `MonadLiftT` inference.
    
    This changes it to *not* extend `MonadLiftT`, instead embedding it as a field, and then writing an explicit `MonadLift` instance.
    
    This is motivated by [lean4#5770](leanprover/lean4#5770), which will log warnings when structures extend parents multiple times.
    kmill committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    cdea48a View commit details
    Browse the repository at this point in the history