Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Description
Fixes a known bug in the rwebaudio (emscripten) driver.
Upon page load, the audio driver, especially on lower end devices, would freeze the page. The console and page would be entirely unresponsive. This fix adds a padding that fixes that issue while preserving audio quality. I dont fully understand why it fixes it, all I can say is that it does
note, you can technically just decrease the blocking check by 1 (
RA.bufIndex === RA.numBuffers-1
) and not increase the overall amount of buffers, but this causes major audio glitches. I dont understand why decreasing it by 2 and increasing the overall amount of buffers fixes this freezing bug, but it does.Related Issues
See EmulatorJS/EmulatorJS#416